Page MenuHomePhabricator
Create Task
Maniphest T224449

Typo in $notMinimumVerisonMessage
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

notMinimumVerisonMessage was introduced in https://phabricator.wikimedia.org/rMWb9073582cf3a8330ca5aa5c1dce054b163eff1d4 and contains a typo.

./includes/installer/PostgresInstaller.php:	protected static $notMinimumVerisonMessage = 'config-postgres-old';
./includes/installer/MssqlInstaller.php:	protected static $notMinimumVerisonMessage = 'config-mssql-old';
./includes/installer/OracleInstaller.php:	protected static $notMinimumVerisonMessage = 'config-oracle-old';
./includes/installer/DatabaseInstaller.php:	protected static $notMinimumVerisonMessage;
./includes/installer/DatabaseInstaller.php:	static::$notMinimumVerisonMessage, static::$minimumVersion, $serverVersion
./includes/installer/SqliteInstaller.php:	protected static $notMinimumVerisonMessage = 'config-outdated-sqlite';
./includes/installer/MysqlInstaller.php:	protected static $notMinimumVerisonMessage = 'config-mysql-old';

Details

SubjectRepoBranchLines +/-
Correct typo `notMinimumVerisonMessage'mediawiki/coremaster+7 -7
Customize query in gerrit

Related Objects

Event Timeline

Aklapper created this task.May 28 2019, 3:33 AM
Aklapper added a comment.May 28 2019, 3:52 AM

(found this while looking at T224374)

RazeSoldier subscribed.May 28 2019, 4:00 AM
DannyS712 claimed this task.Jul 8 2019, 4:38 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 8 2019, 4:38 AM
gerritbot added a comment.Jul 8 2019, 4:39 AM

Change 521197 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Correct typo `notMinimumVerisonMessage'

https://gerrit.wikimedia.org/r/521197

gerritbot added a project: Patch-For-Review.Jul 8 2019, 4:39 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jul 8 2019, 2:26 PM
gerritbot added a comment.Jul 9 2019, 5:22 PM

Change 521197 merged by jenkins-bot:
[mediawiki/core@master] Correct typo `notMinimumVerisonMessage'

https://gerrit.wikimedia.org/r/521197

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 9 2019, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2019, 6:10 PM
DannyS712 closed this task as Resolved.Jul 18 2019, 6:10 PM
DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Jul 19 2019, 9:15 PM
gerritbot added a comment.Aug 20 2019, 12:15 PM

Change 531165 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Switch Failoid in codfw to failoid2001

https://gerrit.wikimedia.org/r/531165

gerritbot added a project: Patch-For-Review.Aug 20 2019, 12:15 PM
DannyS712 removed a project: Patch-For-Review.Aug 20 2019, 1:14 PM

Patch above is unrelated to this task

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits