| WMDE-leszek | |
| May 28 2019, 1:16 PM |
| F30210517: image.png | |
| Sep 3 2019, 5:41 PM |
Fix to issue reported in T221577 https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/497537/ is claimed to cause Wikibase browser tests to fail: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/497443/
Things to investigate:
Maximum time to spend on investigation: 8h
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [DNM] Noop | mediawiki/extensions/Wikibase | master | +1 -0 | |
| Disable CirrusSearch in browser tests | mediawiki/extensions/Wikibase | master | +6 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | PRODUCTION ERROR | aaron | T221577 Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope | ||
| Resolved | Ladsgroup | T224472 Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated |
Related discussions when that change got reverted due to those failures can be found on T218456
A change that was added to test those failures in CI (which depends on unrelated change in core) can be found here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/497443
Change 533956 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Disable CirrusSearch in browser tests
Change 533956 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Disable CirrusSearch in browser tests
Change 534196 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] [DNM] Noop
It seems my patch doesn't fix it (it seems, it fixed the flaky browser tests though). The interesting thing is that the ruby tests are failing only and we should rewrite them to use nodejs anyway.
The failing ones are https://integration.wikimedia.org/ci/job/mwselenium-quibble-docker/17483/console:
Looking at errors like this:
It seems the search can't find the recently created items.
This is result of my investigation: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/497537#message-2cc44c252b1750c49c9e2f84920cc74e3d8184bf
Waiting on response to investigation results from above, in order to decide whether there's anything more to be do on WikibaseLexeme side.
There's nothing we can do here, there has been a patch to fix the issue I mentioned that's merged this. That made the tests pass for wikibase. There's nothing for us.