Implement License Overlay
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tarrow
	May 28 2019, 3:45 PM

Description

Get all the messages that are required:

Cancel
Save

Get "Pseudo Message" from window.mw.config.get('wbCopyright'). Do not html escape this message.

Add Buttons.
Save should emit save event. The save action will be dispatched by the parent component (in this case: Termbox)
The action that saves the preference should be done by this new modal component.
Cancel button should emit an event which will be caught by the parent. The parent component will then hide the modal. (in this case: Termbox)

Details

	Subject	Repo	Branch	Lines +/-
	Add License Overlay	wikibase/termbox	master	+224 -8
	Add license headinge message for termbox	mediawiki/extensions/Wikibase	master	+4 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T219158 'IP visibility' and 'Terms of use' information on termbox editing
Resolved	• Pablo-WMDE	T221835 Add CC0 License overlay popup on termbox editing
Resolved	• Matthias_Geisler_WMDE	T224489 Implement License Overlay

Event Timeline

Tarrow created this task.May 28 2019, 3:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2019, 3:45 PM

Tarrow updated the task description. (Show Details)May 28 2019, 3:53 PM

• Matthias_Geisler_WMDE edited projects, added Wikidata-Termbox-Iteration-17; removed Wikidata-Termbox.Jun 4 2019, 11:21 AM

• Matthias_Geisler_WMDE claimed this task.Jun 4 2019, 11:37 AM

• Matthias_Geisler_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.

Change 514517 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Add License Overlay

https://gerrit.wikimedia.org/r/514517

gerritbot added a project: Patch-For-Review.Jun 5 2019, 4:00 PM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.Jun 5 2019, 4:12 PM

Change 514472 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] Add license headinge message for termbox

https://gerrit.wikimedia.org/r/514472

Change 514472 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add license headinge message for termbox

https://gerrit.wikimedia.org/r/514472

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 6 2019, 10:00 AM

Change 514517 merged by jenkins-bot:
[wikibase/termbox@master] Add License Overlay

https://gerrit.wikimedia.org/r/514517

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2019, 1:10 PM

• Matthias_Geisler_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-17 board.Jun 6 2019, 1:26 PM

Jakob_WMDE closed this task as Resolved.Jul 1 2019, 9:14 AM