Use overlay when clicking save on termbox
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tarrow
	May 28 2019, 3:53 PM

Description

Change publish method to open license in all cases.
Proceed to save entity when save is clicked and hide modal.
Return to edit mode and hide modal when cancel is clicked.

Details

	Subject	Repo	Branch	Lines +/-
	Show license overlay when clicking the publish button	wikibase/termbox	master	+92 -37

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T219158 'IP visibility' and 'Terms of use' information on termbox editing
Resolved	• Pablo-WMDE	T221835 Add CC0 License overlay popup on termbox editing
Resolved	• Matthias_Geisler_WMDE	T224490 Use overlay when clicking save on termbox

Event Timeline

Tarrow created this task.May 28 2019, 3:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2019, 3:53 PM

• Matthias_Geisler_WMDE edited projects, added Wikidata-Termbox-Iteration-17; removed Wikidata-Termbox.Jun 4 2019, 11:21 AM

• Matthias_Geisler_WMDE claimed this task.Jun 6 2019, 10:06 AM

• Matthias_Geisler_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.

Change 514704 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Use overlay when clicking save on termbox

https://gerrit.wikimedia.org/r/514704

gerritbot added a project: Patch-For-Review.Jun 6 2019, 12:20 PM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.Jun 6 2019, 1:26 PM

• Matthias_Geisler_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-17 board.

Change 514704 merged by jenkins-bot:
[wikibase/termbox@master] Show license overlay when clicking the publish button

https://gerrit.wikimedia.org/r/514704

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2019, 2:10 PM

Jakob_WMDE closed this task as Resolved.Jul 1 2019, 9:14 AM