Page MenuHomePhabricator

MultimediaViewer should not use moment.js for a single line
Closed, ResolvedPublic

Description

Moment.js is quite a large library (70K gzipped) and is used only in a single line of code within MultimediaViewer. This line could be replaced with Date.toLocaleString

See T146798, T137775 for related issues.

Details

Related Gerrit Patches:
mediawiki/extensions/MultimediaViewer : masterReplace moment.js with Date.toLocaleString

Event Timeline

simon04 created this task.May 29 2019, 8:47 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptMay 29 2019, 8:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 513209 had a related patch set uploaded (by Simon04; owner: Simon04):
[mediawiki/extensions/MultimediaViewer@master] Replace moment.js with Date.toLocaleString

https://gerrit.wikimedia.org/r/513209

Change 513209 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Replace moment.js with Date.toLocaleString

https://gerrit.wikimedia.org/r/513209

Jdforrester-WMF closed this task as Resolved.May 31 2019, 9:16 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Thank you!