MultimediaViewer should not use moment.js for a single line
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	simon04
	May 29 2019, 8:47 PM

Description

Moment.js is quite a large library (70K gzipped) and is used only in a single line of code within MultimediaViewer. This line could be replaced with [Date.toLocaleString](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleString)

See T146798, T137775 for related issues.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Replace moment.js with Date.toLocaleString	mediawiki/extensions/MultimediaViewer	master	+21 -48

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Resolved	BUG REPORT	kostajh	T324454 Special:Notifications shows the date in English and not in Kurdish on ku.wikipedia
Open	BUG REPORT	None	T391759 Croatian date format in Special:Notifications incorrectly lacks trailing dot
Open		None	T146798 Replace Moment.js in core with mediawiki.DateFormatter, JavaScript Temporal and Intl
Resolved		simon04	T224626 MultimediaViewer should not use moment.js for a single line

Event Timeline

simon04 created this task.May 29 2019, 8:47 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptMay 29 2019, 8:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

simon04 added a parent task: T146798: Replace Moment.js in core with mediawiki.DateFormatter, JavaScript Temporal and Intl.May 29 2019, 8:48 PM

Change 513209 had a related patch set uploaded (by Simon04; owner: Simon04):
[mediawiki/extensions/MultimediaViewer@master] Replace moment.js with Date.toLocaleString

https://gerrit.wikimedia.org/r/513209

gerritbot added a project: Patch-For-Review.May 29 2019, 8:58 PM

Change 513209 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Replace moment.js with Date.toLocaleString

https://gerrit.wikimedia.org/r/513209