Page MenuHomePhabricator

MobileFrontend should not use moment.js for a single line
Open, Needs TriagePublic


Moment.js is quite a large library (70K gzipped) and is used only in a single line (though, loaded asynchronously).

Event Timeline

simon04 created this task.May 29 2019, 10:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2019, 10:36 PM

Change 513233 had a related patch set uploaded (by Simon04; owner: Simon04):
[mediawiki/extensions/MobileFrontend@master] Replace moment.js with Date.toLocaleString

Jdlrobson added a subscriber: Jdlrobson.

There is a problem with the patch as written. I think this should be the editing teams call as I'd hope long term that all editor code would live inside VisualEditor or one of their projects and I'm not sure whether moment.js is part of that. I don't think this is Reading-Web's domain, but let me know if it should be.