Page MenuHomePhabricator
Create Task
Maniphest T224680

Port bin/parserTests.js, the parser tests runner script
Closed, ResolvedPublic
Actions

Description

Parsoid has a parser tests runner which supports a lot of options over and beyond what the existing PHP version of the test runner supports.

So, we have one of two paths forward:

  • Either port the JS version to PHP
  • Copy over the PHP version from core and upgrade it to support the features that the JS version supports

We need to figure out which of the two solutions is simpler and makes more sense.

Details

SubjectRepoBranchLines +/-
Port parserTests script with associated classes and utilsmediawiki/services/parsoidmaster+3 K -4 K
Port mockAPI.js as MockAPIHelper for use with ParserTestsmediawiki/services/parsoidmaster+813 -0
Port ParserTests-specific extensions and enhance ParsoidExtensionAPImediawiki/services/parsoidmaster+221 -37
Port tools/ScriptUtilsmediawiki/services/parsoidmaster+164 -386
WIP: Port tests/TestUtils.php & bin/parserTests.phpmediawiki/services/parsoidmaster+3 K -4 K
Init parserTests runner files via js2phpmediawiki/services/parsoidmaster+3 K -1 K
Port ParserTests Grammar filemediawiki/services/parsoidmaster+1 K -0
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.May 30 2019, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2019, 4:46 PM
ssastry triaged this task as High priority.May 30 2019, 4:48 PM
ssastry added subscribers: Anomie, Tgr.
ssastry moved this task from Backlog to Deployment on the Parsoid-PHP board.May 30 2019, 4:50 PM
ssastry mentioned this in T225841: Run DOMPostProcessor in hybrid testing mode and fix bugs.Jun 24 2019, 9:14 PM
ssastry removed Arlolra as the assignee of this task.Jun 30 2019, 9:33 PM
ssastry added a subscriber: Arlolra.
ssastry claimed this task.EditedJul 2 2019, 3:34 PM

Given our goal of wanting to run parser tests independently in this code base without having MediaWiki checked out and integrated, it makes sense to port our JS runner. The core runner has tighter integration with MediaWiki internals and isn't suitable if we are serious about the isolation goal. If at a later point, this goal is no longer relevant, we can revisit.

But, couple of things that came up in discussion in the parsing team meeting:

  • this needs to run via both command line and via PHPUnit. Core parser tests runner had to do a bunch of refactoring to enable that. So, probably look at that design for our version.
  • we need to figure out how to hook this up with the coverage tool.
  • we would need to replace mockAPI.js (used by the JS parserTests runner) with ParserTests version of SiteConfig, PageConfig, and DataAccess classes. Probably by deriving the exising tests/mocks/Mock* versions of these to hardcode implementation decisions and values specific to parser tests.
  • eventually, we do want a single parser tests runner, and so if there is a way we can use this runner with a --legacy flag to run against the Parser.php parser vs. Parsoid, that would be ideal. But, this is probably better done as part of the "Unify Parsers" phase, not right away.
  • we would also need to support running parser tests for extensions - but, this is harder to support right now till we work out all the details of the extension API, and porting those extensions. So, this is is probably also better done as part of the "Unify Parsers" phase, not right away.
gerritbot added a comment.Jul 2 2019, 11:38 PM

Change 520341 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Port ParserTests Grammar file

https://gerrit.wikimedia.org/r/520341

gerritbot added a project: Patch-For-Review.Jul 2 2019, 11:38 PM
gerritbot added a comment.Jul 3 2019, 12:14 AM

Change 520343 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] js2php: Generate tests/TestUutils.php & update tools/ScriptUtils.php

https://gerrit.wikimedia.org/r/520343

gerritbot added a comment.Jul 5 2019, 4:08 AM

Change 520341 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Port ParserTests Grammar file

https://gerrit.wikimedia.org/r/520341

gerritbot added a comment.Jul 12 2019, 8:46 PM

Change 520343 merged by Subramanya Sastry:
[mediawiki/services/parsoid@master] Init parserTests runner files via js2php

https://gerrit.wikimedia.org/r/520343

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 9:11 PM
gerritbot added a comment.Jul 12 2019, 9:17 PM

Change 520358 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Port tests/TestUtils.php & bin/parserTests.php

https://gerrit.wikimedia.org/r/520358

gerritbot added a project: Patch-For-Review.Jul 12 2019, 9:17 PM
gerritbot added a comment.Jul 15 2019, 10:16 PM

Change 523330 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Port parserTests script with associated classes and utils

https://gerrit.wikimedia.org/r/523330

gerritbot added a comment.Jul 15 2019, 10:18 PM

Change 520358 abandoned by Subramanya Sastry:
WIP: Port tests/TestUtils.php & bin/parserTests.php

Reason:
Covered by gerrit 523330 .. I forgot to update change-id to this patch.

https://gerrit.wikimedia.org/r/520358

gerritbot added a comment.Jul 15 2019, 10:54 PM

Change 521351 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Port tools/ScriptUtils

https://gerrit.wikimedia.org/r/521351

gerritbot added a comment.Jul 15 2019, 10:54 PM

Change 523329 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Port ParserTests-specific extensions and enhance ParsoidExtensionAPI

https://gerrit.wikimedia.org/r/523329

gerritbot added a comment.Jul 15 2019, 10:54 PM

Change 522635 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Port mockAPI.js as MockAPIHelper for use with ParserTests

https://gerrit.wikimedia.org/r/522635

gerritbot added a comment.Jul 16 2019, 6:07 PM

Change 521351 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Port tools/ScriptUtils

https://gerrit.wikimedia.org/r/521351

gerritbot added a comment.Jul 26 2019, 8:34 PM

Change 523329 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Port ParserTests-specific extensions and enhance ParsoidExtensionAPI

https://gerrit.wikimedia.org/r/523329

gerritbot added a comment.Jul 26 2019, 11:27 PM

Change 522635 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Port mockAPI.js as MockAPIHelper for use with ParserTests

https://gerrit.wikimedia.org/r/522635

ssastry moved this task from Deployment to Testing / QA on the Parsoid-PHP board.Jul 30 2019, 4:57 PM
gerritbot added a comment.Jul 30 2019, 8:42 PM

Change 523330 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Port parserTests script with associated classes and utils

https://gerrit.wikimedia.org/r/523330

ssastry closed this task as Resolved.Jul 30 2019, 8:43 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2019, 9:11 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL