Page MenuHomePhabricator
Create Task
Maniphest T224693

Error from ApiPageTriageList.php: "Undefined index: recreated"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: /w/api.php…
Request ID: XPANMgpAIDcAALgOYxEAAAAY

message
PHP Notice: Undefined index: recreated
trace
#0 /srv/mediawiki/php-1.34.0-wmf.7/extensions/PageTriage/includes/Api/ApiPageTriageList.php(452): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.7/extensions/PageTriage/includes/Api/ApiPageTriageList.php(291): MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::buildTagQuery(array)
#2 /srv/mediawiki/php-1.34.0-wmf.7/extensions/PageTriage/includes/Api/ApiPageTriageList.php(71): MediaWiki\Extension\PageTriage\Api\ApiPageTriageList::getPageIds(array)
#3 /srv/mediawiki/php-1.34.0-wmf.7/includes/api/ApiMain.php(1595): MediaWiki\Extension\PageTriage\Api\ApiPageTriageList->execute()
#4 /srv/mediawiki/php-1.34.0-wmf.7/includes/api/ApiMain.php(531): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.34.0-wmf.7/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.34.0-wmf.7/api.php(87): ApiMain->execute()

Impact

(Unknown: To be determined.)

Notes

  • Appears new in 1.34.0-wmf.7. (The error was not observed by Logstash during the 25 days before it.)
  • Affects en.wikipedia.org and test.wikipedia.org.

Example query: action=pagetriagelist&format=json&namespace=0&showreviewed=1&showunreviewed=1&showdeleted=1&showothers=1&recreated=1&dir=newestfirst&limit=20

Details

SubjectRepoBranchLines +/-
Follow-up 4c1c225: Re-bump wgPageTriageCacheVersionmediawiki/extensions/PageTriagemaster+1 -1
Follow-up 4c1c225: Re-bump wgPageTriageCacheVersionmediawiki/extensions/PageTriagewmf/1.34.0-wmf.7+1 -1
Follow-up 4c1c225: Bump wgPageTriageCacheVersionmediawiki/extensions/PageTriagewmf/1.34.0-wmf.7+1 -1
Follow-up 4c1c225: Bump wgPageTriageCacheVersionmediawiki/extensions/PageTriagemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.May 30 2019, 7:05 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 30 2019, 7:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Untriaged to May 2019 / 1.34.wmf.5+ on the Wikimedia-production-error board.May 30 2019, 7:05 PM
MusikAnimal triaged this task as Unbreak Now! priority.May 30 2019, 7:12 PM
MusikAnimal added a project: Community-Tech (Resolved 2018-19 Q4).
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 30 2019, 7:12 PM
Amorymeltzer subscribed.May 30 2019, 7:12 PM
MusikAnimal claimed this task.May 30 2019, 7:14 PM
MusikAnimal added a comment.EditedMay 30 2019, 7:16 PM

We saw this problem on the beta cluster at first, but then it resolved itself. I had assumed it took a minute before update.php ran. But I see now this is also broken on testwiki where it has been for 2 days

Bradv subscribed.May 30 2019, 7:17 PM
MusikAnimal added a comment.May 30 2019, 7:19 PM

I think this has to do with $wgPageTriageCacheVersion from https://github.com/wikimedia/mediawiki-extensions-PageTriage/blob/master/includes/ArticleMetadata.php#L247 . Do we have to bump that manually?

Jdforrester-WMF subscribed.May 30 2019, 7:22 PM
In T224693#5224745, @MusikAnimal wrote:

I think this has to do with $wgPageTriageCacheVersion from https://github.com/wikimedia/mediawiki-extensions-PageTriage/blob/master/includes/ArticleMetadata.php#L247 . Do we have to bump that manually?

It was last changed in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/259278eb451f8ae5aa238db184cb6baa308b2c99 — if the format has changed, presumably that should have been bumped in that change?

Niharika moved this task from Ready to In Development on the Community-Tech (Resolved 2018-19 Q4) board.May 30 2019, 7:25 PM
MusikAnimal added a comment.May 30 2019, 7:27 PM

Yes I suppose so though strangely I don't think I did that on my local, or on beta. @Jdforrester-WMF Do you know where this is defined? It's not in the codebase, and I don't see this setting in our InitialiseSettings.php

MusikAnimal added a comment.May 30 2019, 7:30 PM

Sorry I found it. Let me bump that

gerritbot added a comment.May 30 2019, 7:31 PM

Change 513355 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/extensions/PageTriage@master] Bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513355

gerritbot added a project: Patch-For-Review.May 30 2019, 7:31 PM
Barkeep49 subscribed.May 30 2019, 7:45 PM
gerritbot added a comment.May 30 2019, 7:52 PM

Change 513372 had a related patch set uploaded (by Jforrester; owner: MusikAnimal):
[mediawiki/extensions/PageTriage@wmf/1.34.0-wmf.7] Follow-up 4c1c225: Bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513372

gerritbot added a comment.May 30 2019, 8:19 PM

Change 513355 merged by Jforrester:
[mediawiki/extensions/PageTriage@master] Follow-up 4c1c225: Bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513355

gerritbot added a comment.May 30 2019, 8:51 PM

Change 513372 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.34.0-wmf.7] Follow-up 4c1c225: Bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513372

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).May 30 2019, 9:00 PM
Stashbot added a comment.May 30 2019, 9:10 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-30T21:10:18Z] <niharika29@deploy1001> Synchronized php-1.34.0-wmf.7/extensions/PageTriage: Bump wgPageTriageCacheVersion T224693 (duration: 00m 51s)

Stashbot added a comment.May 30 2019, 9:11 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-30T21:11:08Z] <Krinkle> krinkle@mwmaint1002 Add 1 row to pagetriage_tags table on enwiki, based on PageTriageTagsPatch-recreated.sql. T224693, T189929

Stashbot mentioned this in T189929: Add "previously deleted" as a possible issue in the New Pages Feed.May 30 2019, 9:11 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-30T21:12:40Z] <Krinkle> krinkle@mwmaint1002 Add 1 row to pagetriage_tags table on testwiki db, based on PageTriageTagsPatch-recreated.sql. T224693, T189929

gerritbot added a comment.May 30 2019, 9:18 PM

Change 513495 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/extensions/PageTriage@master] Follow-up 4c1c225: Re-bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513495

Stashbot added a comment.May 30 2019, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-30T21:27:26Z] <Krinkle> krinkle@mwmaint1002 Add 1 row to pagetriage_tags table on test2wiki db, based on PageTriageTagsPatch-recreated.sql. T224693, T189929

gerritbot added a comment.May 30 2019, 9:33 PM

Change 513497 had a related patch set uploaded (by Krinkle; owner: MusikAnimal):
[mediawiki/extensions/PageTriage@wmf/1.34.0-wmf.7] Follow-up 4c1c225: Re-bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513497

gerritbot added a comment.May 30 2019, 10:11 PM

Change 513497 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.34.0-wmf.7] Follow-up 4c1c225: Re-bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513497

MaxSem moved this task from In Development to QA on the Community-Tech (Resolved 2018-19 Q4) board.May 30 2019, 10:19 PM
Stashbot added a comment.May 30 2019, 10:19 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-30T22:19:09Z] <niharika29@deploy1001> Synchronized php-1.34.0-wmf.7/extensions/PageTriage/: Fix broken feed - T224693 (duration: 00m 51s)

Niharika closed this task as Resolved.May 30 2019, 10:26 PM
MusikAnimal moved this task from QA to Done on the Community-Tech (Resolved 2018-19 Q4) board.May 30 2019, 11:49 PM
gerritbot added a comment.May 31 2019, 2:26 PM

Change 513495 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Follow-up 4c1c225: Re-bump wgPageTriageCacheVersion

https://gerrit.wikimedia.org/r/513495

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.8; 2019-06-04); removed MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).May 31 2019, 3:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits