Page MenuHomePhabricator

IABot 2.0beta15 removes HTML comment from archiveurl parameter
Closed, DeclinedPublic

Description

Please see the following 2 edits:

https://en.wikipedia.org/w/index.php?diff=899553777&oldid=899530870&title=Falcon_9&curid=2647515
https://en.wikipedia.org/w/index.php?diff=899553820&oldid=897706584&title=Falcon_9_Full_Thrust&curid=47870562

The bot removed the hidden comment <!-- link to the description page on the TSS website with a link to listen to the episode --> from the archiveurl= when adding an archive.

While in this case the archiveurl added actually links to the page the comment suggest going to (seeming like an improvement) there may be cases were the removal of comments is not desired.

v2.0beta15

Event Timeline

Redalert2fan updated the task description. (Show Details)May 30 2019, 8:47 PM
Cirdan renamed this task from Bot removes comment from archiveurl parameter to IABot 2.0beta15 removes comment from archiveurl parameter.May 31 2019, 10:45 AM
Cirdan renamed this task from IABot 2.0beta15 removes comment from archiveurl parameter to IABot 2.0beta15 removes HTML comment from archiveurl parameter.
Cirdan edited projects, added InternetArchiveBot (v2.0); removed InternetArchiveBot.
Cirdan moved this task from Unsorted to Bugs on the InternetArchiveBot (v2.0) board.
Cirdan added a subscriber: Cirdan.
Redalert2fan updated the task description. (Show Details)May 31 2019, 1:03 PM
Cyberpower678 closed this task as Declined.May 31 2019, 6:07 PM

Sorry but anything that the bot needs to modify will get overwritten. It cannot selectively keep something there. This is because not only will it cause bloat in the code for something very insignificant in terms of occurrence, but comments may no longer apply to the new value. Also other bots may not be able to actually process the value in the template as the comment may throw it off. I would advise moving comments to other fields that IABot doesn't touch. IABot changes the URL, archive URL, access date, archive date, deadurl, and df fields if applicable. By policy the bot will leave behind a clean value that another process can easily read.