Newly added depicted items don’t show Wikidata logo
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	LucasWerkmeister
	May 30 2019, 10:07 PM

Description

When you add “depicts” statements to a file, newly mentioned items don’t have a Wikidata logo next to them, while existing items do. After a page reload, the new items have a logo as well, so there seems to be some difference in client-side and server-side rendering.

During editing:

Screenshot_2019-05-30 File Fieldofwhite png - Test Wikimedia Commons.png (436×802 px, 26 KB)

After saving:

Screenshot_2019-05-30 File Fieldofwhite png - Test Wikimedia Commons(1).png (252×802 px, 18 KB)

After reloading:

Screenshot_2019-05-30 File Fieldofwhite png - Test Wikimedia Commons(2).png (252×802 px, 18 KB)

You can also see it in @SandraF_WMF’s slides for today’s Wikimedia monthly activities meeting (link with timestamp) – at least, I assume that’s why two of the four depicted items in the screenshot are missing the logo.

Acceptance criteria:

Can be tested on https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_08-02-2019_at_16.35.jpg
(page might need a purge on beta due to previous interwiki config error persisting in cache)

Wikidata icons show up next to all existing Q- & P-links
Wikidata icons show up next to Q-link for newly added statement

QA Results

AC	Status	Details
1	✅	T224703#5293501
2	✅	T224703#5293501

Details

	Subject	Repo	Branch	Lines +/-
	Another approach to detecting the repository of items/properties	mediawiki/extensions/WikibaseMediaInfo	master	+108 -28

Customize query in gerrit

Event Timeline

LucasWerkmeister created this task.May 30 2019, 10:07 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptMay 30 2019, 10:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Ramsey-WMF triaged this task as Medium priority.May 31 2019, 6:13 PM

• Ramsey-WMF added projects: Structured-Data-Team-Current-Work, Structured Data Engineering.

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

Change 517060 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Another approach to detecting the repository of items/properties

https://gerrit.wikimedia.org/r/517060

gerritbot added a project: Patch-For-Review.Jun 14 2019, 12:02 PM

matthiasmullie claimed this task.Jun 14 2019, 12:11 PM

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.

Change 517060 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Another approach to detecting the repository of items/properties

https://gerrit.wikimedia.org/r/517060

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 18 2019, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2019, 1:10 PM

matthiasmullie reassigned this task from matthiasmullie to Edtadros.Jun 18 2019, 2:51 PM

matthiasmullie updated the task description. (Show Details)

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.

matthiasmullie subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

Acceptance criteria:

Can be tested on https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_08-02-2019_at_16.35.jpg

✅ AC1: Wikidata icons show up next to all existing Q- & P-links

Screen Shot 2019-06-28 at 5.21.10 PM.png (698×1 px, 99 KB)

✅ AC2: Wikidata icons show up next to Q-link for newly added statement

Screen Shot 2019-06-28 at 5.23.09 PM.png (1×1 px, 147 KB)

@Ramsey-WMF the P-link shows up for a newly added statement. When I add an Item, the Q-link appears. Both appear before and after I publish. The acceptance criteria indicate the Q for a statement. Unless I'm misunderstanding the scope of "statement" vs "item" it appears that the acceptance criteria should be revised. Either way the behavior I observed appears to be the desired behavior in the task description above. I'll set this as passed but I tagged you to this comment for a more detailed review.

Edtadros updated the task description. (Show Details)Jun 29 2019, 12:35 AM

We ended up changing the design to not include the logos anyway

	F29667448: Screen Shot 2019-06-28 at 5.21.10 PM.png
	Jun 29 2019, 12:29 AM

	F29667462: Screen Shot 2019-06-28 at 5.23.09 PM.png
	Jun 29 2019, 12:29 AM

	F29282353: Screenshot_2019-05-30 File Fieldofwhite png - Test Wikimedia Commons.png
	May 30 2019, 10:07 PM

	F29282356: Screenshot_2019-05-30 File Fieldofwhite png - Test Wikimedia Commons(2).png
	May 30 2019, 10:07 PM

	F29282358: Screenshot_2019-05-30 File Fieldofwhite png - Test Wikimedia Commons(1).png
	May 30 2019, 10:07 PM

Newly added depicted items don’t show Wikidata logoClosed, ResolvedPublicActions

Description

QA Results

Details

Event Timeline

Test Result

Acceptance criteria:

Newly added depicted items don’t show Wikidata logo
Closed, ResolvedPublic
Actions