Page MenuHomePhabricator
Create Task
Maniphest T224704

CI build failing for some ext repos due to PhanUndeclaredClassMethod "undeclared class \Block"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

For all PageTriage commits, and possibly other extensions as well. Currently blocking ability to merge masters in those master branches.

<file name="includes/Hooks.php">
  <error line="518" severity="warning" message="Parameter $block has undeclared type \Block" source="PhanUndeclaredTypeParameter"/>
</file>
<file name="includes/PageTriageUtil.php">
  <error line="361" severity="warning" message="Parameter $block has undeclared type \Block" source="PhanUndeclaredTypeParameter"/>
  <error line="376" severity="error" message="Call to method getTarget from undeclared class \Block" source="PhanUndeclaredClassMethod"/>

It seems for some reason Phan isn't understanding the class alias for Block.

Wikimedia production calls to fix: https://codesearch.wmflabs.org/deployed/?q=(new%20Block%5C(%7C%5CbBlock%3A%3ATYPE_%7C%40(param%7Cvar%7Creturn)%20Block%5Cb)&i=nope&files=&repos=

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.May 30 2019, 10:13 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 30 2019, 10:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle mentioned this in T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.May 30 2019, 10:14 PM
Jdforrester-WMF added a project: Anti-Harassment.May 30 2019, 10:15 PM
Restricted Application added a subscriber: MGChecker. · View Herald TranscriptMay 30 2019, 10:15 PM
gerritbot added a comment.May 30 2019, 10:59 PM

Change 513527 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/PageTriage@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513527

gerritbot added a project: Patch-For-Review.May 30 2019, 10:59 PM
Esanders added a subscriber: Esanders.May 30 2019, 11:05 PM

The Block class is only defined as an alias:

class_alias( DatabaseBlock::class, 'Block' );

My guess is that because Phan is a static analyser it can't guarantee it will be able to read the second argument as a class name, so it doesn't try. I'm guessing updating Block to DatabaseBlock (or AbstractBlock) in the affected extensions will fix this.

Tchanders added a comment.May 30 2019, 11:30 PM

We can update the affected extensions.

Is this the first class alias Phan has had to deal with?

gerritbot added a comment.May 30 2019, 11:33 PM

Change 513533 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/Flow@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513533

gerritbot added a comment.May 30 2019, 11:51 PM

Change 513533 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513533

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).May 31 2019, 12:00 AM
gerritbot added a comment.May 31 2019, 12:13 AM

Change 513536 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513536

Jdforrester-WMF added a subscriber: Jdforrester-WMF.May 31 2019, 12:30 AM

Apparently we can use enable_class_alias_support in Phan config somehow, but there are only thirteen prod repos creating a Block class, so…

gerritbot added a comment.May 31 2019, 12:36 AM

Change 513540 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/EventBus@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513540

gerritbot added a comment.May 31 2019, 12:43 AM

Change 513536 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513536

gerritbot added a comment.May 31 2019, 12:54 AM

Change 513527 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513527

gerritbot added a comment.May 31 2019, 1:02 AM

Change 513542 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/GlobalBlocking@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513542

gerritbot added a comment.May 31 2019, 1:07 AM

Change 513540 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513540

gerritbot added a comment.May 31 2019, 2:03 PM

Change 513599 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/LdapAuthentication@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513599

gerritbot added a comment.May 31 2019, 2:04 PM

Change 513600 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/TorBlock@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513600

gerritbot added a comment.May 31 2019, 2:05 PM

Change 513601 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/UserMerge@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513601

gerritbot added a comment.May 31 2019, 2:05 PM

Change 513602 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/EntitySchema@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513602

gerritbot added a comment.May 31 2019, 2:06 PM

Change 513603 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/Wikibase@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513603

gerritbot added a comment.May 31 2019, 2:06 PM

Change 513604 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/WikibaseLexeme@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513604

Umherirrender added a subscriber: Umherirrender.May 31 2019, 2:16 PM

The usage of constant must be adjust, too.

https://codesearch.wmflabs.org/search/?q=%5CbBlock%3A%3ATYPE_&i=nope&files=&repos=

Tchanders added a comment.May 31 2019, 2:29 PM

Thanks @Jdforrester-WMF and @Umherirrender. The extensions that document @param Block, @var Block and @return Block should now have patches updating all their references to Block, tagged with this task.

We'll update the extensions that aren't causing Phan to fail too, but won't tag them here.

Krinkle added a comment.May 31 2019, 3:13 PM
In T224704#5225283, @Tchanders wrote:

We can update the affected extensions.

Is this the first class alias Phan has had to deal with?

We've been doing this for the Wikimedia\Rdbms classes for a while which Phan seems to be fine with. (e.g. ResultWrapper, IDatabase and Database, are global aliases.) I took a quick look at how those are set up and it seems identical to the way you've done it for Block, so I'm not sure why Phan complained about these but not the others.

It's possible that something has regressed in newer Phan versions and/or our configuration of it, and that it might now be broken for IDatabase as well. However, we're not likely to find out about that because we've since fixed it in most of the active repos. It's possible that the older repos still using IDatabase are also broken, in which case we'd find out next time someone proposes a commit for those repos.

gerritbot added a comment.May 31 2019, 3:19 PM

Change 513600 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513600

gerritbot added a comment.May 31 2019, 3:25 PM

Change 513601 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513601

gerritbot added a comment.May 31 2019, 3:27 PM

Change 513602 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513602

Umherirrender added a comment.May 31 2019, 3:32 PM

unnamespaced IDatabase is reported by phan - see for example https://integration.wikimedia.org/ci/job/mwext-php70-phan-docker/30651/console

Jdforrester-WMF updated the task description. (Show Details)May 31 2019, 3:38 PM
gerritbot added a comment.May 31 2019, 3:51 PM

Change 513542 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513542

gerritbot added a comment.May 31 2019, 4:21 PM

Change 513604 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513604

gerritbot added a comment.May 31 2019, 4:21 PM

Change 513599 merged by jenkins-bot:
[mediawiki/extensions/LdapAuthentication@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513599

gerritbot added a comment.May 31 2019, 4:24 PM

Change 513603 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use MediaWiki\Block\DatabaseBlock instead of Block

https://gerrit.wikimedia.org/r/513603

Maintenance_bot removed a project: Patch-For-Review.May 31 2019, 5:10 PM
Niharika edited projects, added Anti-Harassment (Kaf - כ); removed Anti-Harassment.May 31 2019, 6:55 PM
Niharika moved this task from Ready to In Progress on the Anti-Harassment (Kaf - כ) board.
dbarratt assigned this task to Tchanders.May 31 2019, 9:14 PM
Umherirrender mentioned this in T224784: Change mediawiki-phan-config to let phan read class alias.May 31 2019, 9:55 PM
Tchanders moved this task from In Progress to Done on the Anti-Harassment (Kaf - כ) board.Jun 4 2019, 7:39 PM
Niharika edited projects, added Anti-Harassment (Lāmed - ל); removed Anti-Harassment (Kaf - כ).Jun 5 2019, 6:13 PM
Niharika moved this task from Ready to Done on the Anti-Harassment (Lāmed - ל) board.
Niharika closed this task as Resolved.Jun 5 2019, 10:42 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL