Page MenuHomePhabricator

PageTriage tags table on testwiki and test2wiki missing rows
Closed, ResolvedPublic0 Estimated Story Points

Description

Found when working on a production outage where the recreated row wasn't there, we noticed that the user_experience one wasn't present:

INSERT INTO /*_*/pagetriage_tags (ptrt_tag_name, ptrt_tag_desc) VALUES ('user_experience', 'Experience level: newcomer, learner, experienced or anonymous' );

Present on enwiki. (The DB for test2wiki is very out of date and probably should just be dropped with the extension.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae renamed this task from PageTriage tags table on testwiki missing one of the rows to PageTriage tags table on testwiki and test2wiki missing rows.Nov 10 2022, 4:05 AM

Confirmed as of 11/09/22.

Testwiki is missing user_experience

Test2wiki is missing afc_state, copyvio, user_experience

Maybe release a patch that creates a daily cron job that checks if all needed tags are present, and if not adds them? Then the extension will be future proof if we add new tags. Should make a master list of tags in a variable somewhere and use that in any spot that needs the list of tags.

This seems like something that @Ladsgroup would be willing to assist with. Bringing consistency to the database is their middle name :)

Perhaps a PHP solution would be a more permanent solution than the DBAs manually adding the rows. We have a PageTriage 48 hour cronjob set up for all 3 wikis at cron/updatePageTriageQueue.php. Perhaps we can add a constant somewhere with what the pagetriage_page_tags table should look like, then this cronjob checks the table vs the constant and automatically adds any missing rows. This would future proof everything if we added additional page tags in the future.

Ladsgroup claimed this task.
Ladsgroup added a project: DBA.

Sorry for really late response. I've been so busy these days :(

This seems like something that @Ladsgroup would be willing to assist with. Bringing consistency to the database is their middle name :)

Done. I skipped test2wiki though.

Perhaps a PHP solution would be a more permanent solution than the DBAs manually adding the rows. We have a PageTriage 48 hour cronjob set up for all 3 wikis at cron/updatePageTriageQueue.php. Perhaps we can add a constant somewhere with what the pagetriage_page_tags table should look like, then this cronjob checks the table vs the constant and automatically adds any missing rows. This would future proof everything if we added additional page tags in the future.

I personally think it should either have either:

But that's for another ticket, please make a follow up

Since https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/805234 at least wikis with update.php are getting updates of new tags (which does not include wmf wikis).

For tables like content_models and slot_roles the necessary rows are added on first usage by class NameTableStore, which needs some refactoring in the extension.