Page MenuHomePhabricator
Create Task
Maniphest T224735

[AMC] Updates to user pages
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
• alexhollender_WMF
May 31 2019, 3:15 PM
Tags
Referenced Files
F29796806: T224735-3.png
Jul 18 2019, 12:47 AM
F29796823: T224735-4.png
Jul 18 2019, 12:47 AM
F29796793: T224735-2.png
Jul 18 2019, 12:47 AM
F29796749: T224735-1.png
Jul 18 2019, 12:47 AM
F29488652: image.png
Jun 12 2019, 5:16 PM
F29488531: image.png
Jun 12 2019, 5:14 PM
F29189779: contributions rtl.svg
Jun 3 2019, 9:56 PM
F29189776: contributions ltr.svg
Jun 3 2019, 9:56 PM
View All 11 Files
Subscribers
Aklapper
• alexhollender_WMF
Edtadros
• Niedzielski
ovasileva
pmiazga

Description

Description

  • since AMC user pages have the enhanced toolbar + overflow menu they do not need the blue links at the top of the page (below the toolbar)
  • since the Language icon is rarely relevant for user pages it makes sense to remove it from the toolbar to make space for Contributions
currentupdated
image.png (1×750 px, 729 KB)
image.png (1×798 px, 517 KB)
Icon
contributions ltr.svg828 BDownload
contributions rtl.svg1 KBDownload

Acceptance criteria / QA Steps

  • AMC user pages only do not have blue links at the top (Discussion, Contributions, Uploads)
  • AMC user pages only do not have a Language action in the toolbar
  • AMC user pages only have Language action in the overflow menu (regardless of whether it is enabled or disabled)
  • AMC user pages only have a Contributions action in the toolbar
  • There are no visible changes to user pages for non-amc user
  • There are no visible changes to article pages

Developer notes

That blue links on top are called "Secondary actions" both in SkinMinerva and MinervaTemplate

QA Results

ACStatusDetails
1✅T224735#5343996
2✅T224735#5343996

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Extract language/variants check to a servicemediawiki/skins/MinervaNeuemaster+207 -73
On user pages, move language icon from Toolbar to Overflow menumediawiki/skins/MinervaNeuemaster+96 -20
If the Overflow menu is visible, don't render user linksmediawiki/skins/MinervaNeuemaster+5 -1
Add contributions link to toolbar on User pagesmediawiki/skins/MinervaNeuemaster+48 -2
Extract LanguageSwitcher to separate classmediawiki/skins/MinervaNeuemaster+105 -33
Customize query in gerrit

Related Objects

Event Timeline

• alexhollender_WMF created this task.May 31 2019, 3:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2019, 3:15 PM
• alexhollender_WMF updated the task description. (Show Details)May 31 2019, 3:21 PM
• alexhollender_WMF added a subscriber: ovasileva.

@ovasileva I'm not sure if this change is tracked elsewhere. I believe we've discussed it already and think it may have slipped through this cracks, which is my fault.

ovasileva triaged this task as Medium priority.Jun 3 2019, 11:01 AM
ovasileva added a project: Web-Team-Backlog-Archived.
ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.
pmiazga subscribed.Jun 3 2019, 8:36 PM

@alexhollender could you attach the contributions icon, please?

• alexhollender_WMF updated the task description. (Show Details)Jun 3 2019, 9:56 PM

@pmiazga I've added them. Also to note there is T222228. Hopefully that doesn't make things too confusing.

pmiazga added a comment.Jun 4 2019, 11:29 AM

Looks like ready to estimate

pmiazga moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog-Archived board.Jun 4 2019, 11:30 AM
ovasileva updated the task description. (Show Details)Jun 11 2019, 4:48 PM
• alexhollender_WMF updated the task description. (Show Details)Jun 12 2019, 5:14 PM
• alexhollender_WMF updated the task description. (Show Details)Jun 12 2019, 5:16 PM
ovasileva set the point value for this task to 3.Jun 18 2019, 4:34 PM
ovasileva edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog-Archived.
pmiazga updated the task description. (Show Details)Jun 18 2019, 4:36 PM
ovasileva moved this task from Backlog to Stage 1 on the Advanced Mobile Contributions board.Jun 18 2019, 11:27 PM
pmiazga claimed this task.Jun 19 2019, 5:03 PM
pmiazga moved this task from To Do to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
pmiazga added a project: MinervaNeue.
gerritbot added a comment.Jun 20 2019, 3:21 PM

Change 518057 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Extract LanguageSwitcher to separate class

https://gerrit.wikimedia.org/r/518057

gerritbot added a project: Patch-For-Review.Jun 20 2019, 3:21 PM
pmiazga added a comment.Jun 20 2019, 4:03 PM

@alexhollender @ovasileva just to confirm - couple questions:

  • this icon "shuffle" will be shipped with the overflow menu. Overflow menu is a separate feature that currently is enabled for AMC users only, but in the future we might move it to stable. In other words, if we enable Overflow menu for all users, then those icons will be arranged in this way even if users didn't opt into AMC mode
  • what to do with Pages in the user namespace, eg: pages like this one: https://m.mediawiki.org/wiki/User:Leszek_Manicki_(WMDE)/WMDE_Engineering/Processes (This one is in MediaWiki project so doesn't have language icon, but looks like some users have pretty big/complex pages in their User namespace) - do we want to treat those pages same as we treat the main user page?
• alexhollender_WMF added a subscriber: • Niedzielski.Jun 20 2019, 4:07 PM

(a comment I meant to submit on June 12th — submitting here for the record) After speaking further with the team and Nirzar I've resolved to stick with the original design, wherein we move the Language action to the overflow menu in order to make space for Contributions. The task description is up to date.

pmiazga added a comment.Jun 20 2019, 4:46 PM

The task description looks clear, I'm just not sure if the User subpages (example /wiki/User:Pmiazga/MyArticle) should get same treatment as user pages (eg: /wiki/User:Pmiazga).

• alexhollender_WMF added a comment.Jun 20 2019, 4:58 PM
In T224735#5271594, @pmiazga wrote:

@alexhollender @ovasileva just to confirm - couple questions:

  • this icon "shuffle" will be shipped with the overflow menu. Overflow menu is a separate feature that currently is enabled for AMC users only, but in the future we might move it to stable. In other words, if we enable Overflow menu for all users, then those icons will be arranged in this way even if users didn't opt into AMC mode

that sounds right to me. When the overflow menu is enabled we should always make this "icon shuffle" (as you called it).

I think sub-pages should have the same toolbar as the main user page. Are there reasons you're thinking of why that would be weird?

gerritbot added a comment.Jun 20 2019, 8:41 PM

Change 518057 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Extract LanguageSwitcher to separate class

https://gerrit.wikimedia.org/r/518057

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 20 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 9:10 PM
gerritbot added a comment.Jun 21 2019, 8:09 PM

Change 518313 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] If the Overflow menu is visible, don't render userlink

https://gerrit.wikimedia.org/r/518313

gerritbot added a project: Patch-For-Review.Jun 21 2019, 8:09 PM
gerritbot added a comment.Jun 24 2019, 4:27 PM

Change 518755 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Add contributions link to toolbar on User pages

https://gerrit.wikimedia.org/r/518755

gerritbot added a comment.Jun 24 2019, 6:01 PM

Change 518777 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] On user pages, move language icon from Toolbar to Overflow menu

https://gerrit.wikimedia.org/r/518777

pmiazga removed pmiazga as the assignee of this task.Jun 24 2019, 6:02 PM
pmiazga moved this task from Doing to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
MBinder_WMF edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4).Jul 3 2019, 5:42 PM
ovasileva moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 3 2019, 5:44 PM
gerritbot added a comment.Jul 4 2019, 8:03 PM

Change 520804 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Consolidate Page.js instance variables

https://gerrit.wikimedia.org/r/520804

gerritbot added a comment.Jul 4 2019, 8:38 PM

Change 518755 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add contributions link to toolbar on User pages

https://gerrit.wikimedia.org/r/518755

Restricted Repository Identity mentioned this in rSKIN47e8c6ef60a3: Update git submodules.Jul 4 2019, 8:38 PM
gerritbot added a comment.Jul 4 2019, 8:49 PM

Change 518313 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] If the Overflow menu is visible, don't render user links

https://gerrit.wikimedia.org/r/518313

Restricted Repository Identity mentioned this in rSKINc9e524af9c32: Update git submodules.Jul 4 2019, 8:49 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jul 4 2019, 9:00 PM
gerritbot added a comment.Jul 9 2019, 4:12 PM

Change 521532 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Extract language/variants check to a service

https://gerrit.wikimedia.org/r/521532

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 16 2019, 1:15 AM
gerritbot added a comment.Jul 16 2019, 8:09 PM

Change 518777 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] On user pages, move language icon from Toolbar to Overflow menu

https://gerrit.wikimedia.org/r/518777

Restricted Repository Identity mentioned this in rSKIN7348304c841c: Update git submodules.Jul 16 2019, 8:09 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.15; 2019-07-23); removed MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 16 2019, 9:00 PM
gerritbot added a comment.Jul 16 2019, 9:16 PM

Change 521532 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Extract language/variants check to a service

https://gerrit.wikimedia.org/r/521532

Jdlrobson moved this task from Needs More Work to Needs QA on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 16 2019, 9:18 PM
Restricted Repository Identity mentioned this in rSKIN408aa6031d2c: Update git submodules.Jul 16 2019, 9:20 PM
Jdlrobson assigned this task to Edtadros.Jul 16 2019, 10:13 PM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.
Jdlrobson moved this task from Ready for Signoff to Needs QA on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.
pmiazga updated the task description. (Show Details)Jul 17 2019, 1:43 PM
Edtadros reassigned this task from Edtadros to ovasileva.Jul 18 2019, 12:47 AM
Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-2019-20-Q1) board.
Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

✅ AC1: AMC user pages only do not have blue links at the top (Discussion, Contributions, Uploads)

T224735-1.png (2×1 px, 235 KB)

✅ AC2: AMC user pages only do not have a Language action in the toolbar
See AC1

✅ AC3: AMC user pages only have Language action in the overflow menu (regardless of whether it is enabled or disabled)
See AC1

✅ AC4: AMC user pages only have a Contributions action in the toolbar
See AC1

✅ AC5: There are no visible changes to user pages for non-amc user

T224735-3.png (2×1 px, 199 KB)

✅ AC6: There are no visible changes to article pages

AMC ONAMC OFF
T224735-2.png (2×1 px, 380 KB)
T224735-4.png (2×1 px, 389 KB)
Edtadros updated the task description. (Show Details)Jul 18 2019, 12:48 AM
ovasileva closed this task as Resolved.Jul 18 2019, 3:13 PM

Looks great!

Samwalton9-WMF mentioned this in T306873: Evaluate and improve the accessibility of the Overflow menu.Apr 26 2022, 9:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits