Deploy new recommendation-api endpoints for Suggested Edits in RESTBase
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/mediawiki/services/recommendation-api/+/513340/ adds two new endpoints to the Recommendation API for suggesting Commons images for which to add or translate a structured caption.
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/recommendation-api/+/515116/ adds the same for Wikipedia articles for which the corresponding Wikidata item is missing a description.

These should go live during the week of June 24. Storage is not needed. The proposed endpoint structure aims to follow the pattern set by the existing Recommendation API endpoints.

Existing Recommendation API endpoints

/article/creation/morelike/{seed}
/article/creation/translation/{source}{/seed}

Proposed new endpoints

/caption/addition/{target}
/caption/translation/from/{source}/to/{target}
/description/addition/{target}
/description/translation/from/{source}/to/{target}

Details

	Subject	Repo	Branch	Lines +/-
	Config changes for suggested edits endpoints.	mediawiki/services/restbase/deploy	master	+22 -3
	Add allowed domains config for Suggested Edits endpoints	mediawiki/services/recommendation-api/deploy	master	+8 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• Mholloway	T212793 Build infrastructure required to support the Suggested Edits feature
Resolved	• Mholloway	T209997 Create a new API endpoint which returns Commons images in need of a caption or caption translation
Resolved	• Mholloway	T224754 Deploy new recommendation-api endpoints for Suggested Edits in RESTBase
Resolved	• Mholloway	T227042 Suggested edits endpoints do not work in recommendation api for beta domains

Event Timeline

• Mholloway triaged this task as High priority.May 31 2019, 7:45 PM

• Mholloway created this task.

The new proposed end points LGTM.

EvanProdromou subscribed.Jun 5 2019, 3:29 PM

Updated target launch date to June 17 to reflect that deployments are off next week due to the SRE offsite.

In T224754#5237347, @Mholloway wrote:

Updated target launch date to June 17 to reflect that deployments are off next week due to the SRE offsite.

The week of June 17 CPT is out for the offsite too...

@Charlotte @Dbrant See above. The caption endpoints won't go live on the week of 6/17 either, due to the Core Platform Team offsite. Looks like it'll be 6/24 at the earliest.

This shouldn't have any negative effect on you since the labs testing instance is functionally identical in this case, but thought I'd give you a heads-up in any case.

Thanks for the heads up @Mholloway

I'm out next week, so someone will have to pick this up in my stead.

• Mholloway renamed this task from Deploy caption addition/suggestion endpoints to production to Deploy caption addition/suggestion endpoints in RESTBase.Jun 19 2019, 1:26 PM

• Mholloway renamed this task from Deploy caption addition/suggestion endpoints in RESTBase to Deploy new recommendation-api endpoints for Suggested Edits in RESTBase.

• Mholloway updated the task description. (Show Details)

• Mholloway updated the task description. (Show Details)Jun 19 2019, 1:30 PM

Change 518083 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/services/recommendation-api/deploy@master] Add allowed domains config for Suggested Edits endpoints

https://gerrit.wikimedia.org/r/518083

gerritbot added a project: Patch-For-Review.Jun 20 2019, 5:01 PM

• Mholloway mentioned this in rMSRDe0cbd31cc99d: Add allowed domains config for Suggested Edits endpoints.Jun 20 2019, 5:07 PM

Change 518083 merged by Mholloway:
[mediawiki/services/recommendation-api/deploy@master] Add allowed domains config for Suggested Edits endpoints

https://gerrit.wikimedia.org/r/518083

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 6:10 PM

RESTBase PR: https://github.com/wikimedia/restbase/pull/1153

• Mholloway moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 21 2019, 3:43 PM

• Mholloway moved this task from Backlog to Doing on the WikimediaEditorTasks board.Jun 22 2019, 11:56 PM

MSantos subscribed.Jun 24 2019, 4:22 PM

@Charlotte I'll be monitoring the service while @Mholloway is out. Let me know if you have any questions and/or concerns.

This is blocked on CPT/Services per https://github.com/wikimedia/restbase/pull/1153#issuecomment-506385522.

Change 519500 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/services/restbase/deploy@master] Config changes for suggested edits endpoints.

https://gerrit.wikimedia.org/r/519500

gerritbot added a project: Patch-For-Review.Jun 27 2019, 7:56 PM

MSantos reassigned this task from MSantos to • Mholloway.Jul 3 2019, 1:53 PM

Ok, PR merged, config patch updated. Will be deployed on Monday.

• Mholloway moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 5 2019, 4:44 PM

Change 519500 merged by Ppchelko:
[mediawiki/services/restbase/deploy@master] Config changes for suggested edits endpoints.

https://gerrit.wikimedia.org/r/519500

• Pchelolo mentioned this in rGRBD4910a12cce94: Config changes for suggested edits endpoints..Jul 8 2019, 1:46 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-08T13:48:49Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@8e81e98]: Release 1.0, expose talk endpoints T225733, suggestions endpoints T224754, fix summary purging T226983

Stashbot mentioned this in T226983: Page summary endpoint in RESTBase not updated since about June 27.Jul 8 2019, 1:48 PM

The endpoints were deployed and are public now Resolving.

Mentioned in SAL (#wikimedia-operations) [2019-07-08T14:05:01Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@8e81e98]: Release 1.0, expose talk endpoints T225733, suggestions endpoints T224754, fix summary purging T226983 (duration: 16m 11s)

Deploy new recommendation-api endpoints for Suggested Edits in RESTBaseClosed, ResolvedPublicActions