Page MenuHomePhabricator

Add phan to Translate extension
Open, Needs TriagePublic

Description

As wmf deployed extension the Translate extension should run phan on CI to found simple bugs in an earlier state of development.

Translate extension is not using the common /includes/ or /src/ folder, which makes the config for phan a bit harder.
It also has many dependency to take care when running phan to get all classes declared.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2019, 7:55 PM

FYI: Translate predates the practice of using a such directory. I was planning to move files to src together when adding namespaces to them. But I was waiting for core show an example how to add namespaces in backwards compatible manner, but for reasons unknown to me that has been stalled. In theory those two things could be done separately, but I'm afraid that moving them first will make adding namespaces more difficult.

Daimona moved this task from Backlog to Extensions on the phan board.Thu, Sep 12, 5:49 PM