As wmf deployed extension the Translate extension should run phan on CI to found simple bugs in an earlier state of development.
Translate extension is not using the common /includes/ or /src/ folder, which makes the config for phan a bit harder.
It also has many dependency to take care when running phan to get all classes declared.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T179554 Add phan to MediaWiki extensions and skins for static analysis [cloneable] | |||
| Resolved | Umherirrender | T224783 Enable mediawiki/mediawiki-phan-config on all Wikimedia-deployed repositories | |||
| Resolved | Umherirrender | T224756 Add phan to Translate extension |
FYI: Translate predates the practice of using a such directory. I was planning to move files to src together when adding namespaces to them. But I was waiting for core show an example how to add namespaces in backwards compatible manner, but for reasons unknown to me that has been stalled. In theory those two things could be done separately, but I'm afraid that moving them first will make adding namespaces more difficult.
Change 541032 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [Translate] Add phan dependency
Change 541032 merged by jenkins-bot:
[integration/config@master] [Translate] Add phan dependency
Mentioned in SAL (#wikimedia-releng) [2019-10-07T16:51:30Z] <James_F> Zuul: Add phan dependencies for Translate T224756
Change 542713 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Translate@master] build: Add mediawiki/mediawiki-phan-config
Change 544291 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [Translate] Run phan job
Change 544291 merged by jenkins-bot:
[integration/config@master] [Translate] Run phan job
Mentioned in SAL (#wikimedia-releng) [2019-10-20T09:38:26Z] <James_F> Zuul: Run phan job for Translate T224756
Change 542713 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] build: Add mediawiki/mediawiki-phan-config