As wmf deployed extension the WikimediaMaintenance extension should run phan on CI to found simple bugs in an earlier state of development.
WikimediaMaintenance extension is not using the common /includes/ or /src/ folder, which makes the config for phan a bit harder.
Some of the maintenance script are in global scope and than the globals are not detected by phan.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T179554 Add phan to MediaWiki extensions and skins for static analysis [cloneable] | |||
| Resolved | Umherirrender | T224783 Enable mediawiki/mediawiki-phan-config on all Wikimedia-deployed repositories | |||
| Resolved | Umherirrender | T224770 Add phan to WikimediaMaintenance extension |
Change 539938 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [WikimediaMaintenance] Add phan dependency
Change 539938 merged by jenkins-bot:
[integration/config@master] [WikimediaMaintenance] Add phan dependency
Mentioned in SAL (#wikimedia-releng) [2019-09-30T20:47:09Z] <James_F> Zuul: Add phan job for WikibaseQualityConstraints T224773 and some phan dependencies for WikimediaMaintenance T224770.
Change 540202 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WikimediaMaintenance@master] build: Add mediawiki/mediawiki-phan-config
Change 546736 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [WikimediaMaintenance] Run phan job
Change 546736 merged by jenkins-bot:
[integration/config@master] [WikimediaMaintenance] Run phan job
Change 540202 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] build: Add mediawiki/mediawiki-phan-config