Page MenuHomePhabricator

Add phan to WikimediaMaintenance extension
Open, LowestPublic

Description

As wmf deployed extension the WikimediaMaintenance extension should run phan on CI to found simple bugs in an earlier state of development.

WikimediaMaintenance extension is not using the common /includes/ or /src/ folder, which makes the config for phan a bit harder.
Some of the maintenance script are in global scope and than the globals are not detected by phan.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2019, 8:58 PM
Reedy triaged this task as Lowest priority.May 31 2019, 9:17 PM
Daimona moved this task from Backlog to Extensions on the phan board.Sep 12 2019, 5:49 PM

Change 539938 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[integration/config@master] [WikimediaMaintenance] Add phan dependency

https://gerrit.wikimedia.org/r/539938

Change 539938 merged by jenkins-bot:
[integration/config@master] [WikimediaMaintenance] Add phan dependency

https://gerrit.wikimedia.org/r/539938

Mentioned in SAL (#wikimedia-releng) [2019-09-30T20:47:09Z] <James_F> Zuul: Add phan job for WikibaseQualityConstraints T224773 and some phan dependencies for WikimediaMaintenance T224770.

Change 540202 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WikimediaMaintenance@master] build: Add mediawiki/mediawiki-phan-config

https://gerrit.wikimedia.org/r/540202