Page MenuHomePhabricator

Unable to display 3D file: TypeError: mw.mmv.isBrowserSupported is not a function
Closed, ResolvedPublic

Description

Trying to open https://commons.wikimedia.org/wiki/File:Bakelit_Telephone_2D_to_3D.stl in 3D mode with clicking on the "3D" button (upper left corner) or the eye icon (upper right corner). Getting JavaScript error in Firefox and Chrome:

TypeError: mw.mmv.isBrowserSupported is not a function

Using the MediaViewer button below the image works well

Event Timeline

Raymond created this task.Jun 1 2019, 8:45 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJun 1 2019, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Raymond updated the task description. (Show Details)Jun 1 2019, 8:48 PM
Jdforrester-WMF added a project: MediaViewer.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Whoops, caused by b23a32a413b985e93c9de8b6aea51e3aedcdb045 where this function was removed.

Change 513742 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/3D@master] Follow-up b23a32a41: Drop call to now-removed isBrowserSupported method

https://gerrit.wikimedia.org/r/513742

Change 513742 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Follow-up b23a32a41: Drop call to now-removed isBrowserSupported method

https://gerrit.wikimedia.org/r/513742

Change 513743 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/3D@wmf/1.34.0-wmf.7] Follow-up b23a32a41: Drop call to now-removed isBrowserSupported method

https://gerrit.wikimedia.org/r/513743

Change 513743 merged by jenkins-bot:
[mediawiki/extensions/3D@wmf/1.34.0-wmf.7] Follow-up b23a32a41: Drop call to now-removed isBrowserSupported method

https://gerrit.wikimedia.org/r/513743

Mentioned in SAL (#wikimedia-operations) [2019-06-01T22:49:25Z] <krinkle@deploy1001> Synchronized php-1.34.0-wmf.7/extensions/3D/modules/mmv.3d.js: T224812 / bd4fbfddbe1a0 (duration: 01m 07s)

Jdforrester-WMF closed this task as Resolved.Jun 1 2019, 11:19 PM

Thanks Timo, now deployed.

@Jdforrester-WMF Thank you for the very fast patch and deploy. But I am still getting the same error on Firefox. Purging page does not help and loading the page with denug=true neither.

@Jdforrester-WMF Thank you for the very fast patch and deploy. But I am still getting the same error on Firefox. Purging page does not help and loading the page with denug=true neither.

Oh, sorry to hear that. I tested in production and re-confirmed just now on Chrome 74 and Firefox 68.0b7. Possibly ISP-level caching?

@Jdforrester-WMF Thank you for the very fast patch and deploy. But I am still getting the same error on Firefox. Purging page does not help and loading the page with denug=true neither.

Oh, sorry to hear that. I tested in production and re-confirmed just now on Chrome 74 and Firefox 68.0b7. Possibly ISP-level caching?

Today it works well. Thanks anyway.