Page MenuHomePhabricator

Add, remove, or change prominence for depict tags
Closed, ResolvedPublic

Description

Instead of using built in tags from select 2, we need to add our custom tag to the UI on select2:select event, in the same area as existing tags are loaded.
Also add click events for removing tags and changing prominence using the internal controls within each tag.
With this feature complete, you can now see that user edits are being tracked in the UI, as the publish button state updates. The console shows you the current unsaved changes whenever a change is made to depicts or captions.

Note: Our caption inputs are not being populated yet with the image's data. So images which have captions will show as if edits have been made as soon as you land on them (i.e. it thinks you've removed them).

  • For clarity and a central point to add new UI elements for statements, create new ParticipationManager.addDepictsStatement(item, label, description, isProminent)
  • On select search result, we add the statement to the UI
  • isProminent will always be set to false initially, so we can just use participationManager.addDepictsStatement(item, label, description)
  • Setup click event on all 'remove' buttons to allow user to remove existing statements
  • On add and remove, fire the ParticipationManager.depictDataChanged() event

Event Timeline

NavinoEvans moved this task from Pending to In progress on the ISA board.
NavinoEvans renamed this task from Add UI element for depicts tags on select from search to Add/remove UI elements for depict tags on select from search or remove button click.Jun 3 2019, 3:10 PM
NavinoEvans updated the task description. (Show Details)
NavinoEvans updated the task description. (Show Details)
NavinoEvans updated the task description. (Show Details)
NavinoEvans renamed this task from Add/remove UI elements for depict tags on select from search or remove button click to Add, remove, or change prominence for depict tags.Jun 3 2019, 4:09 PM
NavinoEvans updated the task description. (Show Details)

Change 514067 had a related patch set uploaded (by NavinoEvans; owner: NavinoEvans):
[labs/tools/Isa@master] Add, remove, or change prominence for depict tags

https://gerrit.wikimedia.org/r/514067

Change 514067 merged by jenkins-bot:
[labs/tools/Isa@master] Add, remove, or change prominence for depict tags

https://gerrit.wikimedia.org/r/514067