Page MenuHomePhabricator
Create Task
Maniphest T224864

Show error page for all unrecoverable FileImporter errors
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

We do this for some initial validation errors, but we should reuse the error page for unrecoverable errors during the submit action.

Details

SubjectRepoBranchLines +/-
Streamline SpecialImportFile::handleImportException() codemediawiki/extensions/FileImportermaster+18 -14
Show error page on failed importmediawiki/extensions/FileImportermaster+13 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jun 3 2019, 9:19 AM
awight set the point value for this task to 3.
awight moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-05-29 board.Jun 4 2019, 10:19 AM
gerritbot added a comment.Jun 4 2019, 11:07 AM

Change 514262 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] Show error page on failed import

https://gerrit.wikimedia.org/r/514262

gerritbot added a project: Patch-For-Review.Jun 4 2019, 11:07 AM
awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-05-29 board.Jun 4 2019, 11:08 AM
awight mentioned this in rEFLId8a32d969c31: Show error page on failed import.Jun 4 2019, 11:09 AM
WMDE-Fisch mentioned this in rEFLIbc1395f1c902: Show error page on failed import.Jun 5 2019, 12:54 PM
gerritbot added a comment.Jun 5 2019, 1:41 PM

Change 514473 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Streamline SpecialImportFile::handleImportException() code

https://gerrit.wikimedia.org/r/514473

thiemowmde mentioned this in rEFLI447893e6852b: Streamline SpecialImportFile::handleImportException() code.Jun 5 2019, 1:42 PM
thiemowmde mentioned this in rEFLI64f48fcfa4db: Streamline SpecialImportFile::handleImportException() code.Jun 5 2019, 2:48 PM
gerritbot added a comment.Jun 5 2019, 3:07 PM

Change 514262 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Show error page on failed import

https://gerrit.wikimedia.org/r/514262

awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-05-29 board.Jun 5 2019, 3:56 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 5 2019, 4:00 PM
thiemowmde mentioned this in rEFLIdf3ac17c17ec: Streamline SpecialImportFile::handleImportException() code.Jun 6 2019, 9:27 AM
gerritbot added a comment.Jun 11 2019, 8:09 AM

Change 514473 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Streamline SpecialImportFile::handleImportException() code

https://gerrit.wikimedia.org/r/514473

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2019, 8:10 AM
Lea_WMDE moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.Jun 11 2019, 8:44 AM
Lea_WMDE closed this task as Resolved.Jun 12 2019, 1:41 PM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-05-29 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL