useless autopromotion at every request
Open, LowPublic
Actions

Assigned To

None

Authored By

	Domas
	Sep 3 2009, 2:16 PM

Description

AbuseFilter seems to be running quite expensive (relatively) autopromotion code for every request, that involves RPC:

 4.3        > AbuseFilterHooks::onGetAutoPromoteGroups
57.4         > memcached::get

0.000427 3.5 < memcached::get
0.000714 0.0 < AbuseFilterHooks::onGetAutoPromoteGroups

I suggest doing it only when 'expensive' checks are done (e.g. preview, save and editform).

Details

Reference: bz20487

	Subject	Repo	Branch	Lines +/-
	Performance: don't check autopromotion if blockautopromote is disabled	mediawiki/extensions/AbuseFilter	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T172447: Investigate 2017-08-02 Save Timing regression (+40-60%)
Mentioned Here: rEABFe008e68b5f30: Only check for auto-promote block if there is a promotion to block
rEABF2807b5883a9c: Avoid duplicate autopromote block key fetches

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:52 PM

• bzimport added projects: AbuseFilter, Performance Issue.

• bzimport set Reference to bz20487.

• bzimport added a subscriber: Unknown Object (MLST).

Domas created this task.Sep 3 2009, 2:16 PM

that's the consequence of calling $user->getEffectiveGroups() everywhere, which checks implicit groups and autopromotions. Shall we extendend getEffectiveGroups with a $notABigDeal parameter?

• werdna unsubscribed.Dec 10 2014, 6:16 PM

Krinkle mentioned this in T172447: Investigate 2017-08-02 Save Timing regression (+40-60%).Aug 17 2017, 1:32 AM

I guess this was mostly fixed in rEABFe008e68b5f30d1ebe3250c3ef4f49d3c8a68530e and also mitigated in rEABF2807b5883a9c4f7bee11ea4e7992c63dd28c0d9e?

Change 635527 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Performance: don't check autopromotion if blockautopromote is disabled

https://gerrit.wikimedia.org/r/635527

gerritbot added a project: Patch-For-Review.Oct 21 2020, 11:28 AM

Daimona updated the task description. (Show Details)Oct 21 2020, 11:29 AM

Daimona removed a subscriber: • wikibugs-l-list.

Change 635527 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Performance: don't check autopromotion if blockautopromote is disabled

https://gerrit.wikimedia.org/r/635527

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 21 2020, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2020, 2:10 PM

matej_suchanek added a project: TestMe.Jan 1 2021, 9:26 AM

useless autopromotion at every requestOpen, LowPublicActions

Description

Details

Related Objects

Event Timeline

useless autopromotion at every request
Open, LowPublic
Actions