As discussed in last code health metrics meeting.
One idea would be to enable extension-codehealth for all extensions in integration/config which are in the extension-coverage pipeline (~90). Note that if this patch is merged, then we can do a search/replace on extension-coverage with extension-codehealth.
@hashar @thcipriani any concerns about resource usage with enabling the pipeline for this many extensions? Would you prefer for us to do this in smaller increments?
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T224990 Enable codehealth pipeline for more extensions | |||
| Duplicate | BUG REPORT | hashar | T259109 mwext-codehealth-master-non-voting erase doc.wikimedia.org coverage report |
Yes please hold. We lack capacity to run all those additional tests right now :-\ I am stuck not being able to add any more instances due to an ongoing issue. Thank you for asking :-]
Also ideally, I would like the codehealth pipeline to avoid rerunning tests that are already run in the test or coverage pipeline. Though that is arguably a lot more work and deserves another task.
Yes please hold. We lack capacity to run all those additional tests right now :-\ I am stuck not being able to add any more instances due to an ongoing issue. Thank you for asking :-]
OK, please let us know when we could move forward again.
Also ideally, I would like the codehealth pipeline to avoid rerunning tests that are already run in the test or coverage pipeline. Though that is arguably a lot more work and deserves another task.
I've created https://gerrit.wikimedia.org/r/c/integration/config/+/514016 which proposes to drop extension-coverage for extensions which are in extension-codehealth. It still results in a little duplication in that we generate the coverage twice on postmerge. Maybe there's a way to run the cover-extensions-publish publisher from mwext-codehealth-master-non-voting
It still results in a little duplication in that we generate the coverage twice on postmerge. Maybe there's a way to run the cover-extensions-publish publisher from mwext-codehealth-master-non-voting
Update, there is now no duplication of effort / CI resources in the latest patchset.
Change 514016 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Publish coverage reports from extension-codehealth
Change 514016 merged by jenkins-bot:
[integration/config@master] Publish coverage reports from extension-codehealth
Change 517082 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Codehealth: Make mwext-codehealth-master-non-voting synchronous
Change 517082 merged by jenkins-bot:
[integration/config@master] Codehealth: Make mwext-codehealth-master-non-voting synchronous
Change 533866 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Add ORES extension to codehealth pipeline
Change 533889 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Codehealth: Add CirrusSearch to pipeline
Change 533889 merged by jenkins-bot:
[integration/config@master] layout: [CirrusSearch] Switch from coverage to codehealth jobs
Change 533866 merged by jenkins-bot:
[integration/config@master] layout: [ORES] Switch from coverage to codehealth jobs
Mentioned in SAL (#wikimedia-releng) [2019-09-03T21:59:38Z] <James_F> Zuul: Move ORES and CirrusSearch to codehealth T224990
@kostajh, before ore filling another phab task, I would like to ask: is it possible to enable the codehealth pipeline for our node services as well?
@MSantos yes it's possible but I think a separate task makes sense. See T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects. We would probably do something similar to what @Mstyles is working on there.
Change 609146 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] [layout] [GlobalWatchlist] Add to codehealth pipeline
https://gerrit.wikimedia.org/r/c/integration/config/ /609146
Change 609146 merged by jenkins-bot:
[integration/config@master] [layout] [GlobalWatchlist] Add to codehealth pipeline
https://gerrit.wikimedia.org/r/c/integration/config/ /609146
Change 633297 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[integration/config@master] layout: [AbuseFilter] Add extension-codehealth
Change 633297 merged by jenkins-bot:
[integration/config@master] layout: [AbuseFilter] Add extension-codehealth
Mentioned in SAL (#wikimedia-releng) [2020-10-16T19:19:31Z] <James_F> Zuul: [mediawiki/extensions/AbuseFilter] Add extension-codehealth T224990
Note that as of right now there's a long back-log of the post-merge job (mwext-codehealth-master-non-voting), ~6 hours / 51.
https://gerrit.wikimedia.org/r/c/integration/config/+/517082 changed concurrency for the pre-merge job, but explicitly not the post-merge one. Is that still warranted? Perhaps we can go to concurrent for all of them?