Page MenuHomePhabricator
Create Task
Maniphest T224997

Update MobileFrontend-npm-run-lint-modules-docker to run node10
Closed, DeclinedPublic
Actions

Description

https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/jjb/job-templates.yaml#454

Details

SubjectRepoBranchLines +/-
Drop resource-modulesmediawiki/extensions/MobileFrontendmaster+23 -82
jjb: Drop mwext-MobileFrontend-npm-run-lint-modules-dockerintegration/configmaster+0 -35
layout: Drop mwext-MobileFrontend-npm-run-lint-modules-dockerintegration/configmaster+0 -17
mwext-MobileFrontend-npm-run-lint-modules-docker: Make non-voting for nowintegration/configmaster+5 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT302086 Set scap minimum python version to 3.7
 ResolvedNoneT247045 Migrate all of production metal and VMs to Buster or later
 ResolvedakosiarisT249724 Track and remove jessie based container images from production
 ResolvedJdforrester-WMFT224908 Drop jessie testing support
 ResolvedJdforrester-WMFT224907 Drop php55 testing support
 ResolvedReedyT205039 Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205041 Tracking bug for 1.27.6/1.30.2/1.31.2/1.32.2 security release
 ResolvedBawolffT197279 Direct POST to Special:ChangeEmail will bypass reauth check
 ResolvedAnomieT204729 Potential enwiki DOS due to slow WatchedItemStore::countVisitingWatchersMultiple
 ResolvedBawolffT207603 CVE-2019-12471: Loading JS from user space where the username is not a registered account is dangerous and should be banned
 ResolvedBawolffT208881 CSS using var() to create exponential sized calc() on wiki page will crash visitor's browser
 ResolvedLegoktmT199540 Forbid blocking IP ranges as big as /1 and /2, as done on ruwikiquote using the API
 ResolvedLucas_Werkmeister_WMDET212118 API responses for unpatrolled or (not) autopatrolled recent changes require privileges but may be cached publicly
 ResolvedBawolffT209794 Need to make a limit of count of attempts to change email address
 ResolvedsbassettT222036 Exposed suppressed username or log in Special:EditTags
 ResolvedsbassettT222038 Exposed suppressed log in RevisionDelete page
 ResolvedJdforrester-WMFT221739 Patch jQuery due to CVE-2019-11358
 ResolvedsbassettT25227 Use token when logging out
 ResolvedsbassettT221868 Send out wikitech-l post for T25227 ("Use token when logging out")
 ResolvedReedyT205042 Write and send release announcements for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
 ResolvedReedyT205043 Write and send pre-release Announcements for MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedJdforrester-WMFT205044 Update onwiki release notes for 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205046 Update HISTORY in master after 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205047 Tag MW 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT224499 RELEASE-NOTES for 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedJdforrester-WMFT224912 Update MediaWiki.org links and versions
 ResolvedJdforrester-WMFT224913 EOL REL1_27 and REL1_30 onwiki
 ResolvedReedyT225201 Formally announce EOL of MW 1.27 and 1.30
 ResolvedReedyT225149 Update CVEs and publish them
 ResolvedReedyT205048 Obtain CVEs for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
 ResolvedJdforrester-WMFT224906 Drop php56 testing support
 ResolvedhasharT223348 Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x
 ResolvedhasharT210287 Migrate wikimedia-fundraising-civicrm to a Docker container
 ResolvedJdforrester-WMFT224905 Move wikiba.se tests from php56 to php72
 ResolvedhasharT224591 Migrate contint* hosts to Buster
 DeclinedMoritzMuehlenhoffT226236 Upload docker-ce 18.06.3 upstream package for Stretch
 InvalidthciprianiT239880 Replacement hardware for buster/stretch upgrade of contint1001 and contint2001
 ResolvedmmodellT215458 Convert zuul to use scap
 ResolvedhasharT240551 Remove Zuul Debian package from WMCS instances
 ResolvedJoeT249110 Build and publish a python2 based container to build wheels
 ResolvedJMeybohmT249812 Rebuild helm/helm-diff for buster-wikimedia
 ResolvedJMeybohmT250479 Rebuild helmfile for buster-wikimedia
 DuplicateDzahnT210008 upgrade krypton (webserver_misc_apps) to stretch
 DeclinedDzahnT224194 switch webserver_misc_apps to PHP 7.2 (7.1)
 ResolvedJdforrester-WMFT211784 Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects
 ResolvedzeljkofilipinT247833 Mentor a Google Summer of Code 2020 student
 ResolvedVidhi-ModyT247844 Upgrade WebdriverIO to v6 in all repositories
 InvalidVidhi-ModyT234314 Upgrade WebdriverIO to version 5 for all repositories
 OpenNoneT225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
 OpenNoneT234002 Make MediaWiki Wdio tests less slow (Sept 2019)
 ResolvedJdforrester-WMFT197901 Lots of npm WARN deprecated warnings from npm install on MediaWiki core
 ResolvedKrinkleT213268 Upgrade webdriverio to version 5 in mediawiki/core
 ResolvedJdforrester-WMFT222406 Switch quibble-based CI jobs from node6 to node10
 DeclinedJdforrester-WMFT224997 Update MobileFrontend-npm-run-lint-modules-docker to run node10

Event Timeline

Jdforrester-WMF created this task.Jun 4 2019, 3:09 PM

Or switch it off.

• Niedzielski updated the task description. (Show Details)Jun 4 2019, 3:16 PM
Legoktm added a subscriber: Legoktm.Jun 4 2019, 3:20 PM

Previous discussion: T196956#4277695 (I don't remember if there was a follow-up ticket)

If it's valuable, we really need to implement it in a more sustainable way, the current solution has too much tech debt.

gerritbot added a comment.Jun 4 2019, 4:57 PM

Change 514347 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] mwext-MobileFrontend-npm-run-lint-modules-docker: Make non-voting for now

https://gerrit.wikimedia.org/r/514347

gerritbot added a project: Patch-For-Review.Jun 4 2019, 4:57 PM
gerritbot added a comment.Jun 4 2019, 5:29 PM

Change 514347 merged by jenkins-bot:
[integration/config@master] mwext-MobileFrontend-npm-run-lint-modules-docker: Make non-voting for now

https://gerrit.wikimedia.org/r/514347

Stashbot added a comment.Jun 4 2019, 5:31 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-04T17:31:12Z] <James_F> Reloading Zuul to make mwext-MobileFrontend-npm-run-lint-modules-docker non-voting T224997

Jdforrester-WMF triaged this task as High priority.Jun 4 2019, 5:32 PM
Jdforrester-WMF added a project: MobileFrontend.

I've made it non-voting for now, but this is doing actual tests that we want voting soon.

Maintenance_bot removed a project: Patch-For-Review.Jun 4 2019, 6:11 PM
Jdforrester-WMF moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Jun 4 2019, 8:56 PM
hashar mentioned this in T196956: mwext-MobileFrontend-npm-run-lint-modules-docker failing - node script running as php.Jun 5 2019, 7:10 AM
phuedx added a project: Web-Team-Backlog.Jun 7 2019, 7:20 PM
phuedx moved this task from Incoming to Tracking on the Web-Team-Backlog board.
phuedx edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
greg edited projects, added Release-Engineering-Team-TODO (201907); removed Release-Engineering-Team (Kanban).Jul 1 2019, 9:19 PM
greg moved this task from INBOX to Doing on the Release-Engineering-Team-TODO (201907) board.Jul 1 2019, 9:21 PM
Jdlrobson merged a task: T225365: MF tests seemingly broken in REL1_33.Jul 2 2019, 4:44 PM
Jdlrobson added a subscriber: Reedy.
gerritbot added a comment.Jul 8 2019, 7:42 PM

Change 521339 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Drop resource-modules

https://gerrit.wikimedia.org/r/521339

gerritbot added a project: Patch-For-Review.Jul 8 2019, 7:42 PM
Jdlrobson edited projects, added Release-Engineering-Team (Kanban); removed Patch-For-Review, Release-Engineering-Team-TODO (201907).Jul 8 2019, 7:43 PM
Jdlrobson added subscribers: pmiazga, Jdrewniak, Jdlrobson.

Looks like RelEng could do with some direction from us?
I talked about this with @Jdrewniak @pmiazga @Niedzielski and we have decided to remove this from MobileFrontend. We think the library is useful as it makes sure your extension.json has correctly listed its dependencies correctly (e.g. catches cases where you forgot to add your messages to the ResourceLoader module) however it does a lot of stuff that we no longer need (e.g. check dependencies using M.require) and requires a lot of investment that is not valuable enough to give.

The above patch removes it from MobileFrontend and should be seen as permission to remove anywhere else in the Wikimedia stack.

gerritbot added a comment.Jul 8 2019, 11:15 PM

Change 521373 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Drop mwext-MobileFrontend-npm-run-lint-modules-docker

https://gerrit.wikimedia.org/r/521373

gerritbot added a project: Patch-For-Review.Jul 8 2019, 11:15 PM

Change 521374 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Drop mwext-MobileFrontend-npm-run-lint-modules-docker

https://gerrit.wikimedia.org/r/521374

Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO (201907); removed Release-Engineering-Team (Kanban).Jul 8 2019, 11:15 PM
gerritbot added a comment.Jul 8 2019, 11:28 PM

Change 521373 merged by jenkins-bot:
[integration/config@master] layout: Drop mwext-MobileFrontend-npm-run-lint-modules-docker

https://gerrit.wikimedia.org/r/521373

gerritbot added a comment.Jul 8 2019, 11:34 PM

Change 521339 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Drop resource-modules

https://gerrit.wikimedia.org/r/521339

Stashbot added a comment.Jul 8 2019, 11:35 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-08T23:35:23Z] <James_F> Dropping mwext-MobileFrontend-npm-run-lint-modules-docker from Zuul T224997

Jdforrester-WMF closed this task as Declined.Jul 8 2019, 11:37 PM

Removed. Thank you!

gerritbot added a comment.Jul 8 2019, 11:45 PM

Change 521374 merged by jenkins-bot:
[integration/config@master] jjb: Drop mwext-MobileFrontend-npm-run-lint-modules-docker

https://gerrit.wikimedia.org/r/521374

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 9 2019, 12:00 AM
Jdforrester-WMF moved this task from Doing to Completed on the Release-Engineering-Team-TODO (201907) board.Jul 15 2019, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL