Page MenuHomePhabricator

[Bug] TypeError in PopupsContext
Closed, DuplicatePublicPRODUCTION ERROR

Description

Report
PHP Fatal error:  Uncaught TypeError: Argument 4 passed to Popups\PopupsContext::__construct() must implement interface Popups\EventLogging\EventLogger, instance of Popups\EventLogging\MWEventLogger given, called in /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popups/includes/ServiceWirings.php on line 43 and defined in /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popups/includes/PopupsContext.php:95
Stack trace:
#0 /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popups/includes/ServiceWirings.php(43): Popups\PopupsContext->__construct(Object(GlobalVarConfig), Object(ExtensionRegistry), Object(Popups\PopupsGadgetsIntegration), Object(Popups\EventLogging\MWEventLogger))
#1 /srv/mediawiki/php-1.34.0-wmf.7/includes/libs/services/ServiceContainer.php(430): Wikimedia\Services\ServiceContainer->{closure}(Object(MediaWiki\MediaWikiServices))
#2 /srv/mediawiki/php-1.34.0-wmf.7/includes/libs/services/ServiceContainer.php(414): Wikimedia\Services\ServiceContainer->createService('Popups.Context')

PHP Fatal error:  Uncaught TypeError: Argument 4 passed to Popups\PopupsContext::__construct() must implement interface Popups\EventLogging\EventLogger, instance of Popups\EventLogging\MWEventLogger given, called in /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popups/includes/ServiceWirings.php on line 43 and defined in /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popups/includes/PopupsContext.php:95
Stack trace:
#0 /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popups/includes/ServiceWirings.php(43): Popups\PopupsContext->__construct(Object(GlobalVarConfig), Object(ExtensionRegistry), Object(Popups\PopupsGadgetsIntegration), Object(Popups\EventLogging\MWEventLogger))
#1 /srv/mediawiki/php-1.34.0-wmf.7/includes/libs/services/ServiceContainer.php(430): Wikimedia\Services\ServiceContainer->{closure}(Object(MediaWiki\MediaWikiServices))
#2 /srv/mediawiki/php-1.34.0-wmf.7/includes/libs/services/ServiceContainer.php(414): Wikimedia\Services\ServiceContainer->createService('Popups.Context')
#3 /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popu in /srv/mediawiki/php-1.34.0-wmf.7/extensions/Popups/includes/PopupsContext.php on line 95

I am confused by the error as MWEventLogger seems to implement EventLogger and this code hasn't changed recently.

Event Timeline

What I see on the linked kibana error dashboard are 2 errors, in the same second, from the same server, which was just rebooted and just started receiving traffic. It's pretty strange but I doubt there's anything more to it than some issue loading the code while the server is starting up. I even went to the actual access logs on the server, and they show how that specific server wasn't even serving live traffic at the time as it took the server 18 seconds to render the blank page - both on HHVM and php7 I might add!

So, I just guess this looks like an unfortunate event that was never served to a user.

was never served to a user.

This took me a minute to understand, but it's because the two requests that failed were from the health checker (to /wiki/Special:BlankPage?force_php7=1).

And yeah, limited to one server and PHP7, and never seen again. Let's merge for now.

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM