Page MenuHomePhabricator

CentralNotice missing from "Deployed" preset on Codesearch
Closed, ResolvedPublic

Event Timeline

https://gerrit.wikimedia.org/r/plugins/gitiles/labs/codesearch/+/master/write_config.py#99

# Intentionally ignore special_extensions because they're special
return ['mediawiki/' + name for name in conf['extensions']]

Which I copied from wikimediaci_utils. I don't know what my motivation was in intentionally ignoring them, but I guess we probably shouldn't.

IIRC/AIUI, the problem is that CentralNotice is deployed from the wmf_deploy branch, which may or may not be close to master (is that assumption correct?), and hound only supports indexing the master branch (I have a hack in place for ops/puppet, and don't want to repeat it).

I guess @AndyRussG or @Ejegg will know better but wmf_deploy can be several commits ahead of master as they manually merge on the master branch the commits that they want to go with each train IIRC. I'm not sure I was explained why CentralNotice cannot go with wmf-branches as every other extension though.

Krinkle renamed this task from CentralNotice doesn't come back in results for "deployed" code to CentralNotice missing from "Deployed" preset on Codesearch.Sep 24 2019, 1:11 AM

The mediawiki/extensions/CentralNotice repo is not listed in the multi-select field under https://codesearch.wmflabs.org/deployed/.

+1 for indexing the wmf_deploy branch indeed. That seems most closely approximating "WMF Deployed", in the same way that for all other repos "master" is what will automatically be deployed within 5 days.

@Legoktm: Can hound be hacked to just index origin/HEAD? We recently switched HEAD on CentralNotice to point at wmf_deploy and in the usual case HEAD should point at master. We could adjust HEAD on ops/puppet to point to production and then there would be a consistent ref to index from.

My thinking here is just that you'd have one hack that applied to all "special" repos instead of multiple special-cases in the code.

Indexing wmf_deploy is blocked on https://github.com/hound-search/hound/issues/9 / https://github.com/hound-search/hound/pull/275 upstream. If we want to just index master, that should be straightforward.

Ah, I thought we were indexing master whilst waiting for upstream to decide on that patch.

Yeah, let's start with master for now as a starting point.

Change 556511 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/codesearch@master] Index master of special_extensions aka CentralNotice

https://gerrit.wikimedia.org/r/556511

Change 556511 merged by jenkins-bot:
[labs/codesearch@master] Index master of special_extensions aka CentralNotice

https://gerrit.wikimedia.org/r/556511

Krinkle awarded a token.
Krinkle unsubscribed.
Krinkle subscribed.

Nice :)

Legoktm claimed this task.