Compare:
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Index master of special_extensions aka CentralNotice | labs/codesearch | master | +6 -2 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T179536 Unexpected side-effect of CentralNotice wmf_deploy branch strategy | |||
Resolved | Legoktm | T225028 CentralNotice missing from "Deployed" preset on Codesearch |
Event Timeline
IIRC/AIUI, the problem is that CentralNotice is deployed from the wmf_deploy branch, which may or may not be close to master (is that assumption correct?), and hound only supports indexing the master branch (I have a hack in place for ops/puppet, and don't want to repeat it).
I guess @AndyRussG or @Ejegg will know better but wmf_deploy can be several commits ahead of master as they manually merge on the master branch the commits that they want to go with each train IIRC. I'm not sure I was explained why CentralNotice cannot go with wmf-branches as every other extension though.
The mediawiki/extensions/CentralNotice repo is not listed in the multi-select field under https://codesearch.wmflabs.org/deployed/.
+1 for indexing the wmf_deploy branch indeed. That seems most closely approximating "WMF Deployed", in the same way that for all other repos "master" is what will automatically be deployed within 5 days.
@Legoktm: Can hound be hacked to just index origin/HEAD? We recently switched HEAD on CentralNotice to point at wmf_deploy and in the usual case HEAD should point at master. We could adjust HEAD on ops/puppet to point to production and then there would be a consistent ref to index from.
My thinking here is just that you'd have one hack that applied to all "special" repos instead of multiple special-cases in the code.
Indexing wmf_deploy is blocked on https://github.com/hound-search/hound/issues/9 / https://github.com/hound-search/hound/pull/275 upstream. If we want to just index master, that should be straightforward.
Ah, I thought we were indexing master whilst waiting for upstream to decide on that patch.
Change 556511 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/codesearch@master] Index master of special_extensions aka CentralNotice
Change 556511 merged by jenkins-bot:
[labs/codesearch@master] Index master of special_extensions aka CentralNotice