Page MenuHomePhabricator
Create Task
Maniphest T225093

Print media: Remove link underlining on images
Closed, ResolvedPublic
Actions

Description

Seems that the print/PDF styling didn't consider linked inline images, and draws a nice underline across the image

For example: https://en.wikipedia.org/wiki/Wing_configuration

Wing_configuration.pdf814 KBDownload

Screenshot 2019-06-05 at 15.40.10.png (1,000×338 px, 70 KB)

Developer notes

Problematic rule is:

@media print
a {
    border-bottom: 1px solid #aaa;
}

An a.image rule should override it.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Print: Remove underline for image linksTheDJmediawiki/skins/Vectormaster+1 -1
Customize query in gerrit

Event Timeline

TheDJ created this task.Jun 5 2019, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2019, 1:40 PM
TheDJ added a project: Web-Team-Backlog-Archived.Jun 5 2019, 1:41 PM
TheDJ added a project: CSS.
ovasileva triaged this task as Medium priority.Jun 5 2019, 2:47 PM
ovasileva added a project: Product-Infrastructure-Team-Backlog-Deprecated.
LGoto moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Jun 5 2019, 3:32 PM
MJL subscribed.Jun 7 2019, 1:24 PM
Jdlrobson renamed this task from Inline images get link underlining to Print media: Remove link underlining on images.Jul 2 2019, 4:58 PM
Jdlrobson added a project: patch-welcome.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.
Jdlrobson added a project: good first task.Jul 22 2019, 5:25 PM
TheDJ added a project: User-TheDJ.Jul 23 2019, 7:27 AM
Jdlrobson lowered the priority of this task from Medium to Low.Jul 31 2019, 7:00 PM
gerritbot added a comment.Oct 15 2019, 12:45 PM

Change 543132 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/skins/Vector@master] Print: Remove underline for image links

https://gerrit.wikimedia.org/r/543132

gerritbot added a project: Patch-For-Review.Oct 15 2019, 12:45 PM
TheDJ added a comment.Oct 15 2019, 12:49 PM

PS. i'm pretty sure the usage of border-bottom over text-decoration: underline is intentional here, but it's not documented in the CSS sourcecode.....

gerritbot added a comment.Oct 15 2019, 1:53 PM

Change 543132 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Print: Remove underline for image links

https://gerrit.wikimedia.org/r/543132

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 15 2019, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 2:10 PM
TheDJ closed this task as Resolved.Oct 15 2019, 3:24 PM
TheDJ claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits