Page MenuHomePhabricator

Display core version of watchlist page for AMC users
Open, HighPublic3 Story Points

Description

User story

As an experienced editor, I would like to be able to access the entire functionality of the watchlist page from my mobile device so that I can perform my work on mobile

Acceptance criteria

  • all desktop functionality (with tentative exceptions TBD) will be available on mobile - this means we need to disable the redirects for 2 pages - EditWatchlist and Watchlist (see T225127#5446716 assume solution A)
  • use a feature flag to allow us to QA and design review before shipping. Copy the example of wgMFUseDesktopSpecialHistoryPage - and create wgMFUseDesktopSpecialWatchlistPage
  • Make sure styles for Contributions and RecentChanges are used on Watchlist using existing menus. Any new things are out of scope and will be split out into a new task. Don't touch the mixins!
  • Do not touch JS mentioned in problem2 on T225127#5446716. That if a problem will be descoped.

Design notes

The Watchlist page seems to be quite similar to recent changes in terms of appearance and functionality. It contains the same filter component at the top, and a similar list of pages below. Here is a basic design following from the work in T223922:

Basic DesignRefinements

Notes

let's try to use as much of the work we did on recent changes here as well, as filters and list items are extremely similar

Event Timeline

ovasileva created this task.Jun 5 2019, 5:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2019, 5:35 PM
ovasileva triaged this task as Normal priority.Jun 5 2019, 5:35 PM
alexhollender updated the task description. (Show Details)Jun 6 2019, 8:50 PM
ovasileva renamed this task from [EPIC] Display core version of watchlist page for AMC users to Display core version of watchlist page for AMC users.Wed, Aug 28, 3:16 PM
ovasileva raised the priority of this task from Normal to High.
MBinder_WMF updated the task description. (Show Details)Wed, Aug 28, 4:20 PM
MBinder_WMF added a subscriber: MBinder_WMF.

Moved images to a table to allow them to be side by side :)

phuedx updated the task description. (Show Details)Wed, Aug 28, 4:22 PM
Jdlrobson added a subscriber: Jdlrobson.EditedWed, Aug 28, 6:22 PM

We'll likely want to fix the Special:RecentChanges experience before working on this as we'll inherit the same issues. Once that's done I see 2 problems to solve.

Note the watchlist page is actually 4 pages:

Problem 1: Special:EditWatchlist

We currently override both https://en.m.wikipedia.org/wiki/Special:EditWatchlist and https://en.m.wikipedia.org/wiki/Special:Watchlist on mobile. We have tabs at the top of the page to jump between them.

If we switch https://en.m.wikipedia.org/wiki/Special:Watchlist the tabs disappear but a link to Special:EditWatchlist remains:

Solution A: Also redirect Special:EditWatchlist

The page is not pretty but the table of contents link is the only problem with it:


we'll need to make sure that TOC gets removed.
This experience while more powerful is not as pleasant on the eye as the mobile non-AMC version.

Solution B: Continue to use mobile Special:EditWatchlist

problems with doing this is that the tab would only show on Special:EditWatchlist. We'd want to add the tab to Special:Watchlist too


However if we did this the experience may feel a little inconsistent.

Problem 2

There are a few additional DOM elements at the top of the watchlist page we'll need to cleanup.

Unknown

Watchlist has some JS/CSS (resources/src/mediawiki.special/watchlist.css). I'm not sure how compatible it is with Minerva and if that will need to cleanup.

Jdlrobson reassigned this task from Jdrewniak to ovasileva.Tue, Sep 10, 3:42 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdrewniak.

I think this is ready @ovasileva provided we are okay with the scope - get these enabled behind a feature flag doing the minimum possible.

Jdlrobson updated the task description. (Show Details)Tue, Sep 10, 4:19 PM
Jdlrobson updated the task description. (Show Details)
ovasileva removed ovasileva as the assignee of this task.Tue, Sep 10, 4:20 PM
ovasileva set the point value for this task to 3.

Change 537104 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Provide feature for exposing desktop Special:Watchlist page

https://gerrit.wikimedia.org/r/537104

Change 537104 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Provide feature for exposing desktop Special:Watchlist page

https://gerrit.wikimedia.org/r/537104