Move these methods to BlockManager:
We could alternatively make a small, separate service for this.
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Open | None | T225011 Clean up code related to blocking | ||
| Open | None | T225470 Move cookie block methods into a new BlockCookieService | ||
| Resolved | Tchanders | T225141 Move cookie-related logic from User and Block to BlockManager |
Change 514843 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] WIP Move cookie-blocking methods to BlockManager
Change 514843 merged by jenkins-bot:
[mediawiki/core@master] Move cookie-blocking methods to BlockManager
Testing IP and Autoblock cookies locally, looking at:
+ Does the cookie get set at the right time?
+ Do the cookies get cleared at the right time?
+ Is the block applied correctly from the cookie?
Comparing the behaviour to beta and test wiki when I have been unsure.
When testing T206163 on beta, I have included cookie blocks in combination with other blocks. Seeing that the behaviour seems reasonable.
Nothing jumped out to me as a problem.