Page MenuHomePhabricator

Flagged Revs configuration may be broken
Open, Needs TriagePublic

Description

Sorry for the last minute addition of this... I didn't expect quite so much random issues going on

Basically, in an improvement to ongoing maintenance, Flagged Revs configuration may be broken in various ways on various wikis.... If it is, can people please report this to phabricator, and we'll get it remedied ASAP

Related Objects

Event Timeline

Reedy created this task.Jun 5 2019, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2019, 7:57 PM
Reedy changed the task status from Open to Stalled.Jun 5 2019, 8:44 PM

Maybe not needed now...

Wargo added a subscriber: Wargo.Jun 8 2019, 1:33 PM

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

I'm aware of one issue that was reported recently: T225276: FlaggedRevs (statistics) first three namespaces are listed twice. Can you look into that?

Reedy changed the task status from Stalled to Open.Jun 10 2019, 7:27 PM
94rain added a subscriber: 94rain.Jun 12 2019, 12:54 PM

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

Why would that affect production? Apparently we're still on wmf.8, and 57c1ae0 didn't make it into wmf.8. There's still extension-wip.json instead of extension.json.

Reedy added a comment.Jun 21 2019, 5:18 PM

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508

Why would that affect production? Apparently we're still on wmf.8, and 57c1ae0 didn't make it into wmf.8. There's still extension-wip.json instead of extension.json.

We still wfLoadExtension() the wip json file

For future reference, this is presumably due to migration to ext. registration: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/514508
I'm aware of one issue that was reported recently: T225276: FlaggedRevs (statistics) first three namespaces are listed twice. Can you look into that?

I've investigated the cause of T225797, it's definitely due to ext. registration. See T225797#5276094 there.

Change 518396 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Move all FR config to an extension function

https://gerrit.wikimedia.org/r/518396

Change 518396 merged by jenkins-bot:
[operations/mediawiki-config@master] Move all FR config to an extension function

https://gerrit.wikimedia.org/r/518396

Mentioned in SAL (#wikimedia-operations) [2019-06-24T13:50:54Z] <reedy@deploy1001> Synchronized wmf-config/flaggedrevs.php: T225144 T225276 T225414 T225776 T225797 T226054 (duration: 00m 56s)

Udo_T added a subscriber: Udo_T.Jun 24 2019, 3:44 PM