Page MenuHomePhabricator
Create Task
Maniphest T225196

Run Termbox browser tests as part of Wikibase per-patch browser tests jobs
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Acceptance Criteria

  • Browser tests jobs should run with every wikibase patch
  • We should spot any bugs at the latest when we merge the pin

Some Hints
We see that currently the non-mediawiki core tests are loaded via custom globs: https://github.com/wikimedia/mediawiki/blob/master/tests/selenium/wdio.conf.js#L57

This would not capture our tests in the submodule. We would rather not have to patch core to add our tests as another custom glob. We had the idea to create a custom extra spec in wikibase's selenium tests that imports the describe functions from the termbox spec files. Questions remain about how this would work with multiple files.

This will hopefully go away with the resolution of: T199116

Details

SubjectRepoBranchLines +/-
Run termbox tests with Wikibase CImediawiki/extensions/Wikibasemaster+2 -1
Add termbox browser testsmediawiki/extensions/Wikibasemaster+3 -0
Add example config for Termboxmediawiki/extensions/Wikibasemaster+6 -0
Export browser test to run from Wikibasewikibase/termboxmaster+8 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Jun 6 2019, 11:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2019, 11:05 AM
WMDE-leszek set the point value for this task to 5.Jun 6 2019, 11:24 AM
Tarrow updated the task description. (Show Details)Jul 9 2019, 1:55 PM
Tarrow edited projects, added Wikidata-Termbox-Iteration-19; removed Wikidata-Termbox.Jul 9 2019, 2:01 PM
gerritbot added a comment.Jul 11 2019, 2:43 PM

Change 522106 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Export browser test to run from Wikibase

https://gerrit.wikimedia.org/r/522106

gerritbot added a project: Patch-For-Review.Jul 11 2019, 2:43 PM
gerritbot added a comment.Jul 11 2019, 2:46 PM

Change 522107 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add termbox browser tests

https://gerrit.wikimedia.org/r/522107

gerritbot added a comment.Jul 11 2019, 3:04 PM

Change 522106 merged by jenkins-bot:
[wikibase/termbox@master] Export browser test to run from Wikibase

https://gerrit.wikimedia.org/r/522106

Jakob_WMDE mentioned this in rWBTBcc7bd8687cbe: Export browser test to run from Wikibase.Jul 11 2019, 3:04 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-19 board.Jul 11 2019, 3:05 PM
Tarrow added a comment.Jul 11 2019, 3:39 PM

Need to patch:

  • quibble
    • add setting to LocalSettings.php
    • Set SSR timeout to be low so that we don't wait
  • integration config: check that Minerva + MobileFrontend are available
Tarrow closed subtask T227855: Add MobileFrontend to Wikibase CI dependencies as Resolved.Jul 15 2019, 8:39 AM
Tarrow added a project: Wikibase-Termbox-Iteration-20.Jul 15 2019, 8:42 AM
Tarrow moved this task from To Do to Doing on the Wikibase-Termbox-Iteration-20 board.
Tarrow claimed this task.Jul 15 2019, 8:49 AM
gerritbot added a comment.Jul 15 2019, 10:04 AM

Change 523120 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Add example config for Termbox

https://gerrit.wikimedia.org/r/523120

Tarrow added a comment.Jul 15 2019, 10:09 AM

Adding the required dependencies to Wikibase in CI is done.

Adding the config needed to enable Termbox in CI is hopefully done by: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/523120

And then the tests are finally enabled by: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/522107/5

Tarrow moved this task from Doing to Peer Review on the Wikibase-Termbox-Iteration-20 board.Jul 15 2019, 10:30 AM
gerritbot added a comment.Jul 18 2019, 11:48 AM

Change 523120 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add example config for Termbox

https://gerrit.wikimedia.org/r/523120

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 18 2019, 12:00 PM
gerritbot added a comment.Jul 22 2019, 8:57 AM

Change 522107 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add termbox browser tests

https://gerrit.wikimedia.org/r/522107

Tarrow moved this task from Peer Review to Done on the Wikibase-Termbox-Iteration-20 board.Jul 22 2019, 9:09 AM
Jdlrobson mentioned this in T228685: Termbox browser tests blocking merges in Minerva.Jul 22 2019, 6:52 PM
• Pablo-WMDE moved this task from Done to To Do on the Wikibase-Termbox-Iteration-20 board.Jul 23 2019, 8:03 AM
• Pablo-WMDE subscribed.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/525037 happened b/c of T228685: Termbox browser tests blocking merges in Minerva - looks like we need to iterate.

/cc @Jakob_WMDE @Tarrow

• Pablo-WMDE added a subtask: T228685: Termbox browser tests blocking merges in Minerva.Jul 23 2019, 8:05 AM
gerritbot added a comment.Jul 30 2019, 2:53 PM

Change 526439 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Run termbox tests with Wikibase CI

https://gerrit.wikimedia.org/r/526439

Tarrow moved this task from To Do to Peer Review on the Wikibase-Termbox-Iteration-20 board.Jul 31 2019, 10:52 AM
Tarrow moved this task from Peer Review to Done on the Wikibase-Termbox-Iteration-20 board.Aug 5 2019, 2:13 PM
gerritbot added a comment.Aug 5 2019, 3:18 PM

Change 526439 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Run termbox tests with Wikibase CI

https://gerrit.wikimedia.org/r/526439

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.17; 2019-08-06); removed MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Aug 5 2019, 4:01 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.19; 2019-08-20); removed MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 6 2019, 6:01 PM
Ladsgroup closed this task as Resolved.Oct 23 2019, 11:12 AM
Ladsgroup closed subtask T228685: Termbox browser tests blocking merges in Minerva as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL