Page MenuHomePhabricator

[AMC] Reduce margin below Article/Discussion tabs
Closed, ResolvedPublic2 Estimated Story Points

Description

Description

There is a gap between the underline below the active tab and the light gray separator line. We tried to deal with this issue when we initially released the feature but there were too many moving parts so we decided to revisit it later.

Details

currentcorrect
es.m.wikipedia.org_wiki_Estaci%C3%B3n_de_Chemin_d%27Antony(iPhone 6_7_8).png (1×750 px, 111 KB)
es.m.wikipedia.org_wiki_Estaci%C3%B3n_de_Chemin_d%27Antony(iPhone 6_7_8) (1).png (1×750 px, 111 KB)

update the margin on .minerva__tab to margin: 0 10px -1px 0;

Event Timeline

ovasileva triaged this task as Medium priority.Jun 11 2019, 1:53 PM
ovasileva moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.

Change 524756 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Reduce margin below article/discussion tabs.

https://gerrit.wikimedia.org/r/524756

Change 524756 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Reduce margin below article/discussion tabs.

https://gerrit.wikimedia.org/r/524756

Looks great 😍

articleuser page
iOS (Safari)
IMG_2844.PNG (1×750 px, 90 KB)
IMG_2845.PNG (1×750 px, 98 KB)
iOS (Chrome)
IMG_2846.PNG (1×750 px, 118 KB)
IMG_2847.PNG (1×750 px, 98 KB)
Android (Chrome)
Screenshot_20190722-211537.png (2×1 px, 320 KB)
Screenshot_20190722-211544.png (2×1 px, 212 KB)
Desktop (Chrome)
en.m.wikipedia.beta.wmflabs.org_wiki_Felinus_and_Gratian.png (1×1 px, 213 KB)
en.m.wikipedia.beta.wmflabs.org_wiki_User_Example.png (1×1 px, 166 KB)
ovasileva claimed this task.
ovasileva added a subscriber: ovasileva.

looks good, resolving!