Page MenuHomePhabricator

Flaky test "I select item in menu - the item is added to the widget"
Open, NormalPublic

Description

15:18:19 SUMMARY:
15:18:19 ✔ 1450 tests completed
15:18:19 ℹ 7 tests skipped
15:18:19 ✖ 1 test failed
15:18:19 
15:18:19 FAILED TESTS:
15:18:19   wikibase.lexeme.widgets.GrammaticalFeatureListWidget
15:18:19     ✖ I select item in menu - the item is added to the widget
15:18:19       HeadlessChrome 73.0.3683 (Linux 0.0.0)
15:18:19     Expected: "Q1"
15:18:19     Actual: undefined
15:18:19         at http://localhost:9876/load.php?debug=false&lang=en&modules=WikibaseLexeme.tests%7Ccolor-picker%2CdataValues%2CdiffMatchPatch%2Cdompurify%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.articleplaceholder.createArticle%7Cext.centralauth.ForeignApi%7Cext.cite.style%2Cstyles%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%2Ctest%7Cext.echo.api%2Cdm%2Cinit%7Cext.echo.dm.tests%7Cext.eventLogging%2Cflow%7Cext.eventLogging.debug%7Cext.flow.components%2Cdm%2Ctemplating%2Ctests%2Cui%7Cext.flow.dm.tests%7Cext.flow.jquery.conditionalScroll%2CfindWithParent%7Cext.flow.jquery.findWithParent.tests%7Cext.graph.data%2Cvega1%2CvisualEditor%7Cext.graph.visualEditor.test%7Cext.guidedTour.lib%2Cstyles%7Cext.guidedTour.lib.internal%2Ctests%7Cext.templateData.test%7Cext.templateDataGenerator.data%7Cext.uls.common%2Ci18n%2Cinit%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Ctests%7Cext.visualEditor.articleTarget%2Cbase%2CcheckList%2CcommentAnnotation%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cexperimental%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2CmoduleIndicators%2Cmwalienextension%2Cmwcore%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwtransclusion%2CprogressBarWidget%2Crebase%2Csanitize%2CsupportCheck%2Cswitching%2CtargetLoader%2CtempWikitextEditorWidget%2Ctrack%2Cve%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.desktopArticleTarget.init%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7CglobeCoordinate.js%7Cjquery.AnimationEvent%2CPurposedCallbacks%2CaccessKeyLabel%2CanimateWithEvent%2CcheckboxShiftClick%2Cclient%2Ccolor%2CcolorUtil%2Ccookie%2CfocusAt%2CgetAttrs%2ChighlightText%2Ci18n%2Cinputautoexpand%2ClengthLimit%2CmakeCollapsible%2Csuggestions%2CtabIndex%2Ctablesorter%2CtextSelection%2Cthrottle-debounce%2Ctipsy%7Cjquery.event.special.eachchange%7Cjquery.makeCollapsible.styles%7Cjquery.tablesorter.styles%7Cjquery.ui.EditableTemplatedWidget%2CTemplatedWidget&skin=vector&version=01v348t:68:694
15:18:19     
15:18:19

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/22469/console

Event Timeline

kostajh created this task.Jun 6 2019, 7:48 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 6 2019, 7:48 PM

Change 514866 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikibaseLexeme@master] Disable flaky browser test

https://gerrit.wikimedia.org/r/514866

Change 514866 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Disable flaky browser test

https://gerrit.wikimedia.org/r/514866

From the Jenkins build, there are some uncaught errors earlier in the output that are likely related.

WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined', 'TypeError: Cannot read property 'id' of undefined
    at deserializeSense (…)
    at 
    at mightThrow (…)
    at process (…jquery)
WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined', 'TypeError: Cannot read property 'id' of undefined
    at Object.deserializeSense (…)
    at …
    at mightThrow (…)
    at process (…jquery)

Which appears to be coming from WikibaseLexeme:/resources/serialization/LexemeDeserializer.js#67

(Note: The output can be confusing at times because the browser's console output and Karma's result printer are not aware of each other.)

(QUnit tests are not "browser tests", which for us is what we call our selenium integration tests. Perhaps that tag should be renamed. Generally issues with tests are filed under the same component as the subject source code, so no additional tag is needed.)