Page MenuHomePhabricator
Create Task
Maniphest T225289

Wikibase extension type no longer translated on Special:Version
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

As a Wikidata user, I want to read Special:Version in my language.

Problem:
Wikibase registers the wikibase extension type with the interface message version-wikibase as the name (which is used as the heading of a section on Special:Version). In English, this message has the value “Wikibase”, but it’s translated into several other languages, e. g. „Wikibase-Erweiterungen“ in German, «Вики-база» in Russian, or «قاعدة ويكي» in Arabic.

However, the WikibaseSchema extension unconditionally overrides that name with a hard-coded “Wikibase” (in EntitySchemaHooks::onExtensionTypes), replacing any translations.

Example:
https://www.wikidata.org/wiki/Special:Version?uselang=ar#sv-credits-wikibase

Acceptance criteria:

  • The extension type is translated again on Special:Version.

Details

SubjectRepoBranchLines +/-
Use hard-coded 'Wikibase' name for Wikibase extension namemediawiki/extensions/EntitySchemamaster+1 -1
Change the Wikibase extension type to be translated on Special:Versionmediawiki/extensions/EntitySchemamaster+3 -1
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 7 2019, 10:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2019, 10:10 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 7 2019, 10:10 AM
Lydia_Pintscher triaged this task as Medium priority.Jun 12 2019, 8:44 AM
Lydia_Pintscher added a project: Wikidata-Campsite.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
WMDE-leszek set the point value for this task to 2.Jun 12 2019, 12:30 PM
Rosalie_WMDE claimed this task.Jul 1 2019, 1:55 PM
gerritbot added a comment.Jul 1 2019, 1:59 PM

Change 520015 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/EntitySchema@master] Wikibase extension type no longer translated on Special:Version

https://gerrit.wikimedia.org/r/520015

gerritbot added a project: Patch-For-Review.Jul 1 2019, 1:59 PM
Rosalie_WMDE moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jul 1 2019, 2:07 PM
Rosalie_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jul 2 2019, 9:58 AM

Change 520015 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Change the Wikibase extension type to be translated on Special:Version

https://gerrit.wikimedia.org/r/520015

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 2 2019, 10:00 AM
noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 2 2019, 10:01 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2019, 10:10 AM
gerritbot added a comment.Jul 3 2019, 8:36 AM

Change 520383 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/EntitySchema@master] Add version-wikibase language key version-wikibase is used as Wikibase extension name on Special:Version

https://gerrit.wikimedia.org/r/520383

gerritbot added a project: Patch-For-Review.Jul 3 2019, 8:36 AM
Rosalie_WMDE moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 3 2019, 8:45 AM
Rosalie_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 3 2019, 2:14 PM
gerritbot added a comment.Jul 3 2019, 2:49 PM

Change 520383 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Use hard-coded 'Wikibase' name for Wikibase extension name

https://gerrit.wikimedia.org/r/520383

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2019, 3:11 PM
• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 5 2019, 1:20 PM
• alaa_wmde subscribed.

Checked on beta https://wikidata.beta.wmflabs.org/wiki/Special:Version?uselang=ar#sv-credits-wikibase
and it looked exactly the same as in production at the time https://www.wikidata.org/wiki/Special:Version?uselang=ar#sv-credits-wikibase

Since wikibase is installed on both production and beta, the changes cannot be tested. This can be tested only locally without wikibase, an in that case it will use a hardcoded 'wikibase' and not a translated message. That is because without wikibase extension being there, 'wikibase' message won't be defined.

What is interesting here, is that EntitySchema does not require Wikibase it seems, then why should it report wikibase as it's extensions type. Shouldn't it report a different type then?

But that's outside the scope of this task which I'm moving to done as there's nothing left to change nor test on it.

Lydia_Pintscher closed this task as Resolved.Jul 15 2019, 11:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL