Page MenuHomePhabricator

MF tests seemingly broken in REL1_33
Closed, DuplicatePublic

Description

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/515719/
https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-npm-run-lint-modules-docker/5536/console

17:54:46 + exec docker run --workdir /src/extensions/MobileFrontend --volume /srv/jenkins-workspace/workspace/mwext-MobileFrontend-npm-run-lint-modules-docker/src:/src --volume /srv/jenkins-workspace/workspace/mwext-MobileFrontend-npm-run-lint-modules-docker/cache:/cache --volume /srv/jenkins-workspace/workspace/mwext-MobileFrontend-npm-run-lint-modules-docker/log:/log --init --rm --label jenkins.job=mwext-MobileFrontend-npm-run-lint-modules-docker --label jenkins.build=5536 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/npm-php:0.2.0 run-script lint:modules
17:54:46 ++ /usr/bin/env
17:54:46 ++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL|HHVM_REPO_CENTRAL_PATH)='
17:54:47 
17:54:47 > @ lint:modules /src/extensions/MobileFrontend
17:54:47 > resource-modules ./
17:54:47 
17:54:48 
17:54:48 On file: resources/dist/mobile.common.js
17:54:48 Template {"module":"mobile.startup","fileName":"Section.hogan"} already required previously
17:54:48 Line 1 Column 21901
17:54:48 
17:54:48 mw.template.get('mobile.startup', 'Section.hogan')
17:54:48 
17:54:48 
17:54:48 On file: resources/dist/tests.mobilefrontend.js
17:54:48 Template {"module":"mobile.startup","fileName":"Section.hogan"} already required previously
17:54:48 Line 1 Column 70605
17:54:48 
17:54:48 mw.template.get('mobile.startup', 'Section.hogan')
17:54:48 
17:54:48 
17:54:48 On file: resources/dist/tests.mobilefrontend.js
17:54:48 Template {"module":"mobile.editor.overlay","fileName":"saveHeader.hogan"} already required previously
17:54:48 Line 1 Column 102252
17:54:48 
17:54:48 mw.template.get('mobile.editor.overlay', 'saveHeader.hogan')
17:54:48 
17:54:48 
17:54:49 Warning: Not in extension.json (couldn't verify):
17:54:49   resources/dist/mobile.editor.ve.js
17:54:49   resources/dist/mobile.notifications.overlay.js
17:54:49   resources/dist/tests.mobilefrontend.js
17:54:49 
17:54:49 Error: Dependency problems in file: resources/dist/mobile.special.mobilediff.scripts.js:
17:54:49   Required mw.Title defined in file resources/src/mediawiki.Title/Title.js not found in any dependencies
17:54:49 
17:54:49 Error: Dependency problems in file: resources/dist/mobile.categories.overlays.js:
17:54:49   Required mw.Title defined in file resources/src/mediawiki.Title/Title.js not found in any dependencies
17:54:49 
17:54:49 npm ERR! Linux 4.9.0-0.bpo.9-amd64
17:54:49 npm ERR! argv "/usr/bin/nodejs" "/usr/local/bin/npm" "run-script" "lint:modules"
17:54:49 npm ERR! node v6.11.0
17:54:49 npm ERR! npm  v3.8.3
17:54:49 npm ERR! code ELIFECYCLE
17:54:49 npm ERR! @ lint:modules: `resource-modules ./`
17:54:49 npm ERR! Exit status 1
17:54:49 npm ERR! 
17:54:49 npm ERR! Failed at the @ lint:modules script 'resource-modules ./'.
17:54:49 npm ERR! Make sure you have the latest version of node.js and npm installed.
17:54:49 npm ERR! If you do, this is most likely a problem with the  package,
17:54:49 npm ERR! not with npm itself.

Event Timeline

Reedy created this task.Jun 8 2019, 6:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2019, 6:25 PM
Reedy renamed this task from MF seemingly broken in REL1_33 to MF tests seemingly broken in REL1_33.Jun 8 2019, 6:32 PM

I've pushed a workaround. This patch is failing in Wikibase and Flow now.

Krinkle added a subscriber: Krinkle.

Undo if I misunderstood, but this does not appear to be an issue with MW core, nor with a release-bundled extension.