Page MenuHomePhabricator

Closing image in MultimediaViewer does not revert <title> back to article title
Open, Needs TriagePublic

Description

When using the Wikipedia desktop site, clicking on an image on an article page will change the title of the page. Clicking on the X in the top right will close the picture, but the title displayed in the tab will remain the title of the image (it will flicker for a moment to the original title, but changes back to the image title immediately after).

This was tested on en/wikipedia and test2/wikipedia using Chrome 74.

Event Timeline

Snax28 created this task.Jun 9 2019, 11:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2019, 11:30 PM
Aklapper renamed this task from Closing image does not revert title to Closing image in MultimediaViewer does not revert <title> back to article title.Jun 9 2019, 11:44 PM
Aklapper edited projects, added MediaViewer; removed MediaWiki-General.
Restricted Application added a project: Multimedia. · View Herald TranscriptJun 9 2019, 11:44 PM

Hi @Snax28, thanks for taking the time to report this and welcome to Wikimedia Phabricator!

Confirming. Wondering if this is a regression from T77258.

Indeed, cannot reproduce in Firefox.

simon04 claimed this task.Jun 11 2019, 9:50 AM
simon04 added a subscriber: simon04.

Problem does not occur on Firefox.

The issue seems to be related with the chronology of the document.title update and the history.pushState/replaceState call.

Change 516468 had a related patch set uploaded (by Simon04; owner: Simon04):
[mediawiki/extensions/MultimediaViewer@master] Chrome does not revert title to article title

https://gerrit.wikimedia.org/r/516468