Page MenuHomePhabricator

Watchlist options looks bad in non-JavaScript interface
Closed, ResolvedPublic

Description

If Use non-JavaScript interface is checked in preferences, watchlist is displayed badly in Timeless skin.

Event Timeline

putnik created this task.Jun 10 2019, 9:18 AM
putnik updated the task description. (Show Details)

It can be fixed with this code:

.mw-input-with-label {
    display: inline-block;
}

But it is desirable to understand why it has display: block now.

Change 517719 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/skins/Timeless@master] Fix Special:Watchlist options for no-JS

https://gerrit.wikimedia.org/r/517719

Isarra added a subscriber: Isarra.Jun 19 2019, 6:37 PM

Ugh, it looks like this is only the watchlist (recentchanges is fine) and can show up with or without browser js...

But it is desirable to understand why it has display: block now.

The reason for the display:block in general is to put labels on their own line above text inputs and the like for consistency with how forms are done with ooui. For whatever reason it seems to be breaking the watchlist form, but not anything else I checked...

Change 517719 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Fix Special:Watchlist options for no-JS

https://gerrit.wikimedia.org/r/517719

Change 520338 had a related patch set uploaded (by Paladox; owner: Jack Phoenix):
[mediawiki/skins/Timeless@REL1_33] Fix Special:Watchlist options for no-JS

https://gerrit.wikimedia.org/r/520338

Change 520338 merged by jenkins-bot:
[mediawiki/skins/Timeless@REL1_33] Fix Special:Watchlist options for no-JS

https://gerrit.wikimedia.org/r/520338

Isarra closed this task as Resolved.Fri, Aug 16, 5:14 PM
Isarra claimed this task.

Man, without the patch-for-review I keep losing track of things that have already been reviewed/merged and resolved... >.>

Man, without the patch-for-review I keep losing track of things that have already been reviewed/merged and resolved... >.>

And one (e.g. me) doesn’t notice the lack of the issue…