Maniphest T225413

A lot of tests fails after badges for sitelinks where implemented
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Jun 10 2019, 9:30 AM

Tags

Referenced Files

None

Subscribers

pywikibot-bugs-list

Description

Aftert rPWBC2bcc51aaf5f5 was merged, a lot of tests fails due to a key error,
see https://api.travis-ci.org/v3/job/543449559/log.txt

The reason is that there are ItemPages with link to closed wikis

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Add closed_wikis to Family.langs property	pywikibot/core	master	+5 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Goal	Xqt	T225591 Make Travis and Appveyor pass again
		Resolved		Xqt	T225413 A lot of tests fails after badges for sitelinks where implemented
		Resolved	BUG REPORT	Dalba	T225590 test_own_client_wikidatatest fails for wikidata:test
		Resolved	BUG REPORT	Dalba	T225723 APISite.fromDBName does not work for some wikis
		Resolved	BUG REPORT	Xqt	T225459 TestObsoleteSite test methods fails with AssertionError
		Resolved	BUG REPORT	Xqt	T225504 test_page_from_repository_de_wp method of site_tests.TestCategoryFromWikibase testMethod fails
		Resolved		Xqt	T225482 test_site_link method of link_tests.TestSiteLink fails with AssertionError
		Resolved		Xqt	T225631 test_template of l10n.TestValidTemplate fails for several sites
		Resolved		Xqt	T226934 wikimedia_sites wrongly includes obsolete sites

Event Timeline

Xqt created this task.Jun 10 2019, 9:30 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 10 2019, 9:30 AM

Xqt triaged this task as High priority.Jun 10 2019, 9:31 AM

Change 516185 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Add closed_wikis to Family.langs property

https://gerrit.wikimedia.org/r/516185

gerritbot added a project: Patch-For-Review.Jun 10 2019, 9:56 AM

Change 516216 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] redirect 'mo' site code to 'ro'

https://gerrit.wikimedia.org/r/516216

Change 516185 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Add closed_wikis to Family.langs property

https://gerrit.wikimedia.org/r/516185

@Xqt Thanks for catching and fixing these.

Xqt added a subtask: T225590: test_own_client_wikidatatest fails for wikidata:test.Jun 12 2019, 8:09 AM

Xqt added a subtask: T225459: TestObsoleteSite test methods fails with AssertionError.

Xqt added a parent task: T225591: Make Travis and Appveyor pass again.

Xqt added a subtask: T225504: test_page_from_repository_de_wp method of site_tests.TestCategoryFromWikibase testMethod fails.Jun 12 2019, 8:12 AM

Xqt added a subtask: T225482: test_site_link method of link_tests.TestSiteLink fails with AssertionError.

Xqt added a subtask: T225631: test_template of l10n.TestValidTemplate fails for several sites.Jun 12 2019, 2:38 PM

Xqt removed a project: Patch-For-Review.Jun 12 2019, 3:30 PM

Xqt closed subtask T225459: TestObsoleteSite test methods fails with AssertionError as Resolved.Jun 15 2019, 1:09 PM

Xqt added a subtask: T226934: wikimedia_sites wrongly includes obsolete sites.Jun 30 2019, 12:01 PM

Xqt closed subtask T226934: wikimedia_sites wrongly includes obsolete sites as Resolved.Jun 30 2019, 7:38 PM

Xqt closed subtask T225590: test_own_client_wikidatatest fails for wikidata:test as Resolved.Jul 17 2019, 5:17 PM

Is there anything left to do?

In T225413#5781030, @Dvorapa wrote:

Is there anything left to do?

I guess yes:
T225631 with https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/516636/

Change 563714 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Skip SiteDefinitionError for wikisource urls

https://gerrit.wikimedia.org/r/563714

gerritbot added a project: Patch-For-Review.Jan 12 2020, 12:49 PM

Xqt removed Xqt as the assignee of this task.Jan 12 2020, 12:53 PM

Xqt removed a project: Patch-For-Review.

Huji closed subtask T225631: test_template of l10n.TestValidTemplate fails for several sites as Resolved.Jan 12 2020, 2:45 PM

All subtasks are solved