Page MenuHomePhabricator

Minerva - Special:ContentTranslation displays TypeError:"options is null"
Closed, ResolvedPublic


In enwiki (wmf.8) with MinerveNeue skin enabled, go to Special:ContentTranslation page - when page is loaded, the Console will display the following error

TypeError: "options is null"
    jQuery 3

More details:

Exception in module-execute in module skins.minerva.scripts: load.php:67
TypeError: "options is null"
    jQuery 3
    runScript load.php:637
    cssHandle load.php:677
    flushCssBuffer load.php:269

Event Timeline

Change 522550 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Guard against undefined config variable

Jdlrobson added a subscriber: Jdlrobson.

I get a different error:

load.php?lang=en&modules=startup&only=scripts&raw=1&skin=minerva:2 TypeError: Cannot set property 'activator' of null

when I visit or

The problem is wgMinervaMenuData is being scrubbed from output. Looks like it's easily solved but will need someone from ContentTranslation team to review and confirm this patch fixes the problem:

Change 522550 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Guard against undefined config variable

No console errors for ContentTranslation with Minerva skin.

There seems to be some UI regression though:

Screen Shot 2019-08-05 at 2.11.42 PM.png (318×853 px, 40 KB)
(filed as T229886).