Minerva - Special:ContentTranslation displays TypeError:"options is null"
Closed, ResolvedPublic
Actions

Description

In enwiki (wmf.8) with MinerveNeue skin enabled, go to Special:ContentTranslation page - when page is loaded, the Console will display the following error

TypeError: "options is null"
    jQuery 3
    runScript https://en.wikipedia.org/w/load.php?lang=en&modules=startup&only=scripts&skin=minerva:13
    cssHandle https://en.wikipedia.org/w/load.php?lang=en&modules=startup&only=scripts&skin=minerva:14
    flushCssBuffer https://en.wikipedia.org/w/load.php?lang=en&modules=startup&only=scripts&skin=minerva:6

More details:

Exception in module-execute in module skins.minerva.scripts: load.php:67
TypeError: "options is null"
    jQuery 3
    
    createMainMenu
    
    <anonymous>
    
    <anonymous>
    runScript load.php:637
    cssHandle load.php:677
    flushCssBuffer load.php:269

Details

Related Gerrit Patches:

mediawiki/skins/MinervaNeue : master

Guard against undefined config variable

Related Objects

Mentioned In: rSKINa9940f5e1969: Update git submodules
T208159: ContentTranslation doesn't load on Minerva mobile
Mentioned Here: T229886: [wmf.16] MinervaNeue- CX page UI issues

Event Timeline

Etonkovidova created this task.Jun 10 2019, 12:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2019, 12:14 PM

Etonkovidova mentioned this in T208159: ContentTranslation doesn't load on Minerva mobile.Jun 10 2019, 12:19 PM

Jdlrobson added a project: ContentTranslation.Jul 9 2019, 3:17 PM

Change 522550 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Guard against undefined config variable

https://gerrit.wikimedia.org/r/522550

gerritbot added a project: Patch-For-Review.Jul 12 2019, 8:07 PM

I get a different error:

load.php?lang=en&modules=startup&only=scripts&raw=1&skin=minerva:2 TypeError: Cannot set property 'activator' of null

when I visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation?useskin=minerva or https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation

The problem is wgMinervaMenuData is being scrubbed from output. Looks like it's easily solved but will need someone from ContentTranslation team to review and confirm this patch fixes the problem:

Jdlrobson added a project: Language-Team (Language-2019-July-September).Jul 12 2019, 8:07 PM

Change 522550 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Guard against undefined config variable

https://gerrit.wikimedia.org/r/522550

Gerrit Code Review <gerrit@wikimedia.org> mentioned this in rSKINa9940f5e1969: Update git submodules.Jul 15 2019, 1:47 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 2:10 PM

Looks fixed on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation - @Etonkovidova can you confirm?

Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.Jul 30 2019, 1:06 PM

No console errors for ContentTranslation with Minerva skin.

There seems to be some UI regression though: