Page MenuHomePhabricator

Regularise editing permissions for (semi-)protected pages across desktop and mobile
Closed, ResolvedPublicBUG REPORT

Description

See discussion below. Extended-confirmed and above (e.g., sysop) accounts have permission to edit semi-protected pages on the desktop site, but this is apparently not allowed on mobile. Pinging the Trust and Safety folks to see what the reasoning is/was, and whether this is something we should regularise.


Video of original issue: https://drive.google.com/file/d/1-IaVIGn-TVk6zXN6lU82eTH0TBRQ3_oJ/view?usp=drivesdk

From OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11088016

Event Timeline

@Charlotte I cannot reproduce it using my general account. If someone has an admin account, please let him/her test if it is possible to reproduce as well.

And, it would be better if you or Robin can reply to the user to ask for re-installing the app to see if it solves the issue.

@ABorbaWMF - Can you find a test account that has admin privileges, and see if you can reproduce Vorlod's problem?

Hi, I think there was a misunderstanding: my account does not have admin permissions. Reinstalling the app has no effect whatsoever in beta or not. Thanks

Charlotte renamed this task from Logged in admin user still shows as logged-out in menu, cannot edit semi-protected pages to [BUG] Logged in user still shows as logged-out in menu, cannot edit semi-protected pages.Jul 8 2019, 10:32 PM

Hi, @Vorlod

Since I cannot reproduce this issue, could you please try to update your password or to reinstall the app to see if it happens again?

Hi @cooltey

Unfortunately it does not work.

@ABorbaWMF - Could you please look into the possibility of getting a test user account with the same permissions as @Vorlod to see if we can reproduce this?

@Charlotte - I'm looking into finding an admin account

@ABorbaWMF - I'm not a admin on frWP. I'm just autopatrolled.

Seems that for quite a while 'confirmed' users have been unable to edit semi-protected pages in the app, despite having permissions on web. Merging all these together. @ABorbaWMF - any update on getting a 'confirmed' account to test with?

... any update on getting a 'confirmed' account to test with?

My other account @IAV originally had confirmed permissions along with extended confirmed and did not have access to semi-protected pages. It seems like only auto-confirmed has access to semi-protected pages on mobile.

Workaround: Any users who just have 'sysop' right or rights that gives you permission to edit extended confirmed, semi-protected pages on desktop, add yourself to auto-confirmed group if you're not in it. You can request this on WP:PERM.

Thanks for the workaround @Apap04. @Vorlod, let us know if this works for you. Meanwhile, we will discuss regularising the permissions, so that they are the same on mobile as on desktop.

Charlotte renamed this task from [BUG] Logged in user still shows as logged-out in menu, cannot edit semi-protected pages to Regularise editing permissions for semi-protected pages across desktop and mobile.Nov 5 2019, 2:41 PM
Charlotte updated the task description. (Show Details)

I've already got this right and this doesn't change anything in app. This is my rights: https://fr.wikipedia.org/wiki/Spécial:Permissions/Vorlod . Thanks

Charlotte renamed this task from Regularise editing permissions for semi-protected pages across desktop and mobile to Regularise editing permissions for (semi-)protected pages across desktop and mobile.Apr 1 2020, 7:55 PM

For information, I don't have this problem in 2.7.50309-alpha-2020-02-04 version.

Hi,

I confirm this bug. I'm admin on fr.wikipedia.org and the mobile app doesn't allow to edit protected pages showing a little padlock on every edit button and popuping this message when button cliked: "Sorry, your account doesn't have enough rights to modify this page" (<-- translated from french).

App version is : r/2.7.50341-r-2021-02-02

It's pretty annoying, and I think this bug should be adressed.

Thanks.

I'm not sure if anyone of the developers has admin account at test.wikipedia, but if not, we can grant the rights to someone of you to help with those issues.

Note:
Dmitry has admin account on testwiki, and Johan has admin account svwiki. We can simply get the user group from mobile-html and check it with the app's userinfo to see if the user has the correct edit permission.

Note:
Dmitry has admin account on testwiki, and Johan has admin account svwiki. We can simply get the user group from mobile-html and check it with the app's userinfo to see if the user has the correct edit permission.

Note: Please do not check based on user groups an user is a member of, instead, check user rights. Several user groups can provide permissions to edit (semi)protected pages, and it can (and often is) different for each wiki. https://meta.wikimedia.org/w/api.php?action=query&meta=userinfo&uiprop=rights would be the right way to check for user rights.

@Dbrant @JTannerWMF Based on the comments this may be fixed, but I don't have an admin account. Perhaps we can recruit someone with an admin account and an android to test this? It appears Dmitry and Johan have accounts, but I'm not sure of Johan's account on Phab so I couldn't ccn he here.

We solved the issue by making a slight change to the logic of the editing workflow:
Tapping the edit pencil in the article will always allow you to enter the edit screen. And once inside the edit screen, we explicitly check (via a separate API call) whether the current user is able to edit the article. (And if not, the Publish button is disabled, but you can still see the wikitext of the article.)