Page MenuHomePhabricator

Previous update token is not preserved
Closed, ResolvedPublic1 Estimated Story Points

Description

When using the address update form with a token, a new token is generated after and stored in the database. The previously used token should be preserved in the field previous_identifier, but it seems that this is also overwritten with the newly generated token.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen set the point value for this task to 3.Jun 11 2019, 9:34 AM
kai.nissen changed the point value for this task from 3 to 1.
kai.nissen moved this task from Todo to Test on the WMDE-FUN-Sprint-2019-06-24 board.

Doesn't seem to be fixed on the test system.

Before address change:

mysql> select * from address_change where id = 2734012;
+---------+------------+--------------------------------------+---------------------+--------------+-------------+---------------------+---------------------+------------------+
| id      | address_id | current_identifier                   | previous_identifier | address_type | export_date | created_at          | modified_at         | donation_receipt |
+---------+------------+--------------------------------------+---------------------+--------------+-------------+---------------------+---------------------+------------------+
| 2734012 |       NULL | 8c9cc740-8267-4b20-84c1-23d2adad7768 | NULL                | person       | NULL        | 2019-06-24 16:38:46 | 2019-06-24 16:38:46 |                0 |
+---------+------------+--------------------------------------+---------------------+--------------+-------------+---------------------+---------------------+------------------+
1 row in set (0,00 sec)

After:

mysql> select * from address_change where id = 2734012;
+---------+------------+--------------------------------------+--------------------------------------+--------------+-------------+---------------------+---------------------+------------------+
| id      | address_id | current_identifier                   | previous_identifier                  | address_type | export_date | created_at          | modified_at         | donation_receipt |
+---------+------------+--------------------------------------+--------------------------------------+--------------+-------------+---------------------+---------------------+------------------+
| 2734012 |       4810 | 4c157dbc-d976-4e7f-91ea-0c4123a3c0c9 | 4c157dbc-d976-4e7f-91ea-0c4123a3c0c9 | person       | NULL        | 2019-06-24 16:38:46 | 2019-06-24 16:45:27 |                0 |
+---------+------------+--------------------------------------+--------------------------------------+--------------+-------------+---------------------+---------------------+------------------+
1 row in set (0,00 sec)