Page MenuHomePhabricator

Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet
Open, Stalled, LowPublic

Description

Depends-On is sometimes missed by code reviewers, leaving them confused that the patch set they just +2'ed does not merge. We've had more than one case (if only I could find them) of changes being merged by manually +v2'ing, breaking things and creating a mess because the change it depended on had not been merged.

Jenkins-bot should warn that there are still unmerged changes, just like it warns that it can't merge changes because of conflicts or whatnot.

Example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/511353, which depends on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/511446.

Event Timeline

Mainframe98 renamed this task from Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet. to Jenkins-bot should warn that a patch set has changes it depends on that haven't been merged yet.Jun 11 2019, 10:51 AM
hashar changed the task status from Open to Stalled.Jun 12 2019, 1:21 PM
hashar triaged this task as Low priority.
hashar added a subscriber: hashar.

That is for Zuul. It does log debug message for the action it takes, but those are not reported back to Gerrit. It is a good idea but our zuul version is frozen and we do not add new features to it. When we come to a newer CI system (which might be the next version of zuul), we will revisit this task.