Page MenuHomePhabricator
Create Task
Maniphest T225507

Create delegating preference repository
Closed, ResolvedPublic
Actions

Description

  • create delegating repository
    • delegates to CookieUserPreferenceRepository or a MWApiUserPreferenceRepository depending on log in state of the user
  • can be implemented with a generic return type (the two delegates must match)
  • delegates based on a username parameter ( window as MwWindow ).mw.config.get( 'wgUserName' ) which is null in case the user is anonymous
  • consider extracting the isLoggedIn check into a separate service

Details

SubjectRepoBranchLines +/-
Introduce UserInfoServicewikibase/termboxmaster+64 -0
DelegatingUserPreferenceRepository: first introductionwikibase/termboxmaster+75 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jun 11 2019, 12:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2019, 12:22 PM
Jakob_WMDE edited projects, added Wikidata-Termbox-Iteration-17; removed Wikidata-Termbox.Jun 11 2019, 12:31 PM
• Pablo-WMDE claimed this task.Jun 11 2019, 2:31 PM
• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.
gerritbot added a comment.Jun 11 2019, 3:57 PM

Change 516512 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] DelegatingUserPreferenceRepository: first introduction

https://gerrit.wikimedia.org/r/516512

gerritbot added a project: Patch-For-Review.Jun 11 2019, 3:57 PM
gerritbot added a comment.Jun 17 2019, 5:26 AM

Change 517264 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introduce UserInfoService

https://gerrit.wikimedia.org/r/517264

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.Jun 17 2019, 9:06 AM
WMDE-leszek added a project: Wikidata-Termbox-Iteration-18.Jun 17 2019, 11:37 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-18 board.
gerritbot added a comment.Jun 17 2019, 4:10 PM

Change 516512 merged by jenkins-bot:
[wikibase/termbox@master] DelegatingUserPreferenceRepository: first introduction

https://gerrit.wikimedia.org/r/516512

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-18 board.Jun 18 2019, 9:00 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM
Addshore subscribed.Oct 28 2019, 7:58 AM

This is marked as done in Wikidata-Termbox-Iteration-18
Should this be resolved?

Aklapper removed • Pablo-WMDE as the assignee of this task.Dec 14 2020, 1:16 PM
Aklapper added a subscriber: • Pablo-WMDE.

Resetting inactive assignee. Question by Addshore still stands.

Jakob_WMDE closed this task as Resolved.Dec 14 2020, 2:24 PM
Jakob_WMDE claimed this task.
gerritbot added a comment.Mar 10 2021, 11:29 AM

Change 517264 abandoned by Addshore:
[wikibase/termbox@master] Introduce UserInfoService

Reason:
Abandoning old outdated things from 2019

https://gerrit.wikimedia.org/r/517264

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2021, 9:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL