Page MenuHomePhabricator

Create delegating preference repository
Open, Needs TriagePublic

Description

  • create delegating repository
    • delegates to CookieUserPreferenceRepository or a MWApiUserPreferenceRepository depending on log in state of the user
  • can be implemented with a generic return type (the two delegates must match)
  • delegates based on a username parameter ( window as MwWindow ).mw.config.get( 'wgUserName' ) which is null in case the user is anonymous
  • consider extracting the isLoggedIn check into a separate service

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2019, 12:22 PM
Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.

Change 516512 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] DelegatingUserPreferenceRepository: first introduction

https://gerrit.wikimedia.org/r/516512

Change 517264 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introduce UserInfoService

https://gerrit.wikimedia.org/r/517264

Change 516512 merged by jenkins-bot:
[wikibase/termbox@master] DelegatingUserPreferenceRepository: first introduction

https://gerrit.wikimedia.org/r/516512

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM