Page MenuHomePhabricator
Create Task
Maniphest T225509

Wire up license warning checkbox
Open, Needs TriagePublic
Actions

Description

  • compare current version in the mw config vs the store version
    • never show the overlay if they match
  • wire up the delegating repository in client-entry.ts
    • we can probably (?) get rid of the path that is currently set for the cookie
    • cookie expires in 10 years
    • wikibase.acknowledgedcopyrightversion is the cookie key
    • wb-acknowledgedcopyrightversion is the user option key
  • dispatch the user preference setting action in the license overlay component
  • add the checkbox
    • needs a message

Details

Related Gerrit Patches:
wikibase/termbox : masterWire up license warning checkbox
mediawiki/extensions/Wikibase : masterAdd license warning checkbox label

Related Objects
Search...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2019, 12:30 PM
Jakob_WMDE updated the task description. (Show Details)Jun 11 2019, 12:49 PM
gerritbot added a comment.Jun 14 2019, 10:10 AM

Change 517025 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Introduce the ACKNOWLEDGED_COPYRIGHT_VERSION preference

https://gerrit.wikimedia.org/r/517025

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM
Jakob_WMDE claimed this task.Jun 24 2019, 2:37 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-18 board.
gerritbot added a comment.Jun 25 2019, 8:55 AM

Change 518924 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add license warning checkbox label

https://gerrit.wikimedia.org/r/518924

gerritbot added a comment.Jun 28 2019, 9:15 AM

Change 518924 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add license warning checkbox label

https://gerrit.wikimedia.org/r/518924

gerritbot added a comment.Jun 28 2019, 9:20 AM

Change 517025 merged by jenkins-bot:
[wikibase/termbox@master] Wire up license warning checkbox

https://gerrit.wikimedia.org/r/517025

Addshore added a subscriber: Addshore.Oct 28 2019, 7:57 AM

This is marked as done in Wikidata-Termbox-Iteration-18
Should this be resolved?

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL