Page MenuHomePhabricator
Create Task
Maniphest T225509

Wire up license warning checkbox
Open, Needs TriagePublic
Actions

Description

  • compare current version in the mw config vs the store version
    • never show the overlay if they match
  • wire up the delegating repository in client-entry.ts
    • we can probably (?) get rid of the path that is currently set for the cookie
    • cookie expires in 10 years
    • wikibase.acknowledgedcopyrightversion is the cookie key
    • wb-acknowledgedcopyrightversion is the user option key
  • dispatch the user preference setting action in the license overlay component
  • add the checkbox
    • needs a message

Details

ProjectBranchLines +/-Subject
wikibase/termboxmaster+202 -25Wire up license warning checkbox
mediawiki/extensions/Wikibasemaster+2 -0Add license warning checkbox label
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jun 11 2019, 12:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2019, 12:30 PM
Jakob_WMDE edited projects, added Wikidata-Termbox-Iteration-17; removed Wikidata-Termbox.Jun 11 2019, 12:32 PM
Jakob_WMDE updated the task description. (Show Details)Jun 11 2019, 12:49 PM
gerritbot added a comment.Jun 14 2019, 10:10 AM

Change 517025 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Introduce the ACKNOWLEDGED_COPYRIGHT_VERSION preference

https://gerrit.wikimedia.org/r/517025

gerritbot added a project: Patch-For-Review.Jun 14 2019, 10:10 AM
WMDE-leszek added a project: Wikidata-Termbox-Iteration-18.Jun 17 2019, 11:35 AM
• Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:25 PM
Jakob_WMDE claimed this task.Jun 24 2019, 2:37 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-18 board.
gerritbot added a comment.Jun 25 2019, 8:55 AM

Change 518924 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add license warning checkbox label

https://gerrit.wikimedia.org/r/518924

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-18 board.Jun 25 2019, 5:18 PM
gerritbot added a comment.Jun 28 2019, 9:15 AM

Change 518924 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add license warning checkbox label

https://gerrit.wikimedia.org/r/518924

gerritbot added a comment.Jun 28 2019, 9:20 AM

Change 517025 merged by jenkins-bot:
[wikibase/termbox@master] Wire up license warning checkbox

https://gerrit.wikimedia.org/r/517025

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-18 board.Jun 28 2019, 9:24 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jun 28 2019, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 28 2019, 10:10 AM
• Addshore added a subscriber: • Addshore.Oct 28 2019, 7:57 AM

This is marked as done in Wikidata-Termbox-Iteration-18
Should this be resolved?

Aklapper removed Jakob_WMDE as the assignee of this task.Jul 2 2021, 5:06 AM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL