Page MenuHomePhabricator

Article tagline should be set by a hook, not by code highly coupled with Wikibase
Open, LowPublic

Description

MobileFrontend can show nice article taglines (can be enabled by MFDisplayWikibaseDescriptions) . Sadly, this feature causes a hard dependency on WikiBase, and maitenance cost, as MobileFrontend has to know how to build Wikibase entities. It's not MobileFrontend reponsibility, thus should be removed from MobileFrontend codebase.

Acceptance Criteria

  • Article tagline is set up by the hook. MobileFrontendHooks::findTagLine should run a new hook.
  • Wikibase Client runs the hook to fill the Article tagline
  • ExtMobileFrontend::getWikibaseEntity() and ExtMobileFrontend::getWikibaseDescription() should be removed

Open questions

  • Should we rename the MFDisplayWikibaseDescriptions config?
  • Should we rename MobileContext:shouldShowWikibaseDescriptions() method?

Developer notes:

Proposed Hook name: MobileFrontendFetchArticleTagline

The best place to call the hook most probably is the SkinMinerva::getTaglineHtml() - we could abandon the wgMFDescription variable.
This would not only untagle MobileFrontend and Wikibase, but also remove one dependency between MobileFrontend and Minvera

Event Timeline

pmiazga created this task.Jun 11 2019, 3:41 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 11 2019, 3:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
pmiazga updated the task description. (Show Details)Jun 13 2019, 5:43 PM
Addshore moved this task from incoming to monitoring on the Wikidata board.Jun 22 2019, 9:49 PM
Jdlrobson triaged this task as Low priority.Jul 8 2019, 9:01 PM
Jdlrobson added a subscriber: Jdlrobson.

Not a top priority but definitely something that needs to happen and likely requires involvement and guidance first from the Wikibase folk.

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 15 2019, 4:29 PM