@Cntlsn -- I think this idea generally makes sense, and that the business rules for when to show it won't be too complicated. I think it would just be: if all the articles in your activated module have a clock, show a clock on the preview. Right?

@Cntlsn -- do you think the toast should show if someone taps the icon in the preview? Or that by tapping the icon in the preview, they should just go to the full module, and they can tap the icon again there and get the toast?

A question for @SBisson: when you are looking at the ten most recent articles edited and deciding which to put in the list of five in the module, do you count articles with no calculated pageviews (i.e. edits from today) in the set of ten? When choosing the five to display, do you count them as edits with zero views (and therefore rank them at the bottom? Above or below articles who have actual 0 views after calculation?)

In T225560#5251351, @MMiller_WMF wrote:

@Cntlsn -- do you think the toast should show if someone taps the icon in the preview? Or that by tapping the icon in the preview, they should just go to the full module, and they can tap the icon again there and get the toast?

The entire module preview is a link to go to the module details. I'm not sure making a small part of it respond to tap differently would be intuitive or really usable.

A question for @SBisson: when you are looking at the ten most recent articles edited and deciding which to put in the list of five in the module, do you count articles with no calculated pageviews (i.e. edits from today) in the set of ten? When choosing the five to display, do you count them as edits with zero views (and therefore rank them at the bottom? Above or below articles who have actual 0 views after calculation?)

This is what we do (I hope it correspond to the initial specs of the impact module)

1. We take the 10 unique articles that were edited most recently (if the same article is edited twice recently, it only takes one spot in the top ten)
2. For each article, we get the date when it was first edited and get the page views from that date until yesterday (max 60 days span)
3. We sort by page views. Articles with "N/A" page views are sorted below articles with a number for page views. 0 page views is impossible but if it were, it would be sorted between "N/A" and 1.
4. We total the page views for the top 10 to show on the mobile preview
5. We pick the top 5 (based on page views count) to show on the detailed version (mobile and desktop) of the module.

Let me know if anything is unclear or unexpected.

@MMiller_WMF @SBisson
I agree that the whole preview card should link to the fullscreen view of the impact module.

The business rule "if all the articles in your activated module have a clock, show a clock on the preview" sounds correct to me.

The business rule "if all the articles in your activated module have a clock, show a clock on the preview" sounds correct to me.

@Cntlsn is this the only item of work that is supposed to be done for this task?

@kostajh yes, I think so!

Change 519491 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Show pending icon if no pageviews exist for any edit

https://gerrit.wikimedia.org/r/519491

Change 519491 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Show pending icon if no pageviews exist for any edit

https://gerrit.wikimedia.org/r/519491

Checked in betalabs - the clock icon is shown only when there are no pageviews exist for any edit, i.e. no zero pageviews.

@Etonkovidova Thanks!

@kostajh @SBisson @Catrope can we set

.growthexperiments-homepage-impact-mobile-totalviews {
  padding-left: 10px;
}

so that the text doesn't get too close to the icon/number displayed on smaller screens? Thx!

Change 522520 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: mobile preview: padding between text and icon

https://gerrit.wikimedia.org/r/522520

Change 522520 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: mobile preview: padding between text and icon

https://gerrit.wikimedia.org/r/522520

@Cntlsn - please take a look and may close the task (QA work is done).

Thanks @Etonkovidova.
@MMiller_WMF Looks good to me, apart from the clock icon/number alignment in the module preview, for which a task has been created already T227104.