Page MenuHomePhabricator
Create Task
Maniphest T225594

UserWarning: Site objects have been created before arguments were handled
Closed, ResolvedPublic
Actions

Description

During tests there are some Userwarnings:

WARNING: c:\projects\pywikibot-g4xqx\pywikibot\bot.py:907: UserWarning: Site objects have been created before arguments were handled
  UserWarning)

This occures for script test which uses pywikibot.handle_args and using Site objects. If there are multiple tests using handle_args and Site object the second use of handle_args causes this warning because the global variable _sites is no longer empty and contains Site objects.

How to proceed in this matter?

  • filter this warning for all tests or
  • filter this warning for all related tests or
  • don't throw this warning if a test is running or
  • clear_sites dict after tests are done or
  • ?

Details

SubjectRepoBranchLines +/-
[bugfix] clear _sites cache if called with pwb wrapperpywikibot/coremaster+20 -31
[bugfix] clear _sites cache if called with pwb wrapperpywikibot/coremaster+20 -31
[tests] Suppress all warningspywikibot/coremaster+98 -48
[tests] Suppress Userwarning about already created sitespywikibot/coremaster+38 -16
[tests] Suppress Userwarning about already created sitespywikibot/coremaster+11 -6
Customize query in gerrit

Related Objects

Event Timeline

Xqt created this task.Jun 12 2019, 8:33 AM
Restricted Application added a project: Pywikibot. · View Herald TranscriptJun 12 2019, 8:33 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript
Xqt triaged this task as Low priority.Jun 12 2019, 8:33 AM
Xqt updated the task description. (Show Details)
Mpaa subscribed.Jan 24 2020, 10:21 PM

clear_sites dict after tests are done

Xqt claimed this task.Feb 12 2020, 9:06 AM
gerritbot added a comment.Feb 12 2020, 10:10 AM

Change 571686 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Suppress Userwarning about already created sites

https://gerrit.wikimedia.org/r/571686

gerritbot added a project: Patch-For-Review.Feb 12 2020, 10:10 AM
gerritbot added a comment.Feb 12 2020, 10:44 AM

Change 571686 merged by jenkins-bot:
[pywikibot/core@master] [tests] Suppress Userwarning about already created sites

https://gerrit.wikimedia.org/r/571686

Xqt mentioned this in rPWBC9ed55b177ed0: [tests] Suppress Userwarning about already created sites.Feb 12 2020, 10:46 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 12 2020, 11:10 AM
gerritbot added a comment.Feb 12 2020, 11:53 AM

Change 571706 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Suppress Userwarning about already created sites

https://gerrit.wikimedia.org/r/571706

gerritbot added a project: Patch-For-Review.Feb 12 2020, 11:53 AM
gerritbot added a comment.Feb 12 2020, 12:02 PM

Change 571706 merged by jenkins-bot:
[pywikibot/core@master] [tests] Suppress Userwarning about already created sites

https://gerrit.wikimedia.org/r/571706

Xqt mentioned this in rPWBCb51583fb504f: [tests] Suppress Userwarning about already created sites.Feb 12 2020, 12:03 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 12 2020, 12:11 PM
gerritbot added a comment.Apr 7 2021, 10:29 PM

Change 677383 had a related patch set uploaded (by Damian; author: Damian):

[pywikibot/core@master] [tests] Suppress all warnings

https://gerrit.wikimedia.org/r/677383

gerritbot added a project: Patch-For-Review.Apr 7 2021, 10:29 PM
gerritbot added a comment.Apr 8 2021, 4:45 AM

Change 677383 merged by jenkins-bot:

[pywikibot/core@master] [tests] Suppress all warnings

https://gerrit.wikimedia.org/r/677383

Restricted Repository Identity mentioned this in rPWBC8f193da286f2: [tests] Suppress all warnings.Apr 8 2021, 4:47 AM
Xqt removed Xqt as the assignee of this task.Apr 25 2022, 8:11 AM
Xqt removed a project: Patch-For-Review.
Xqt merged a task: T264591: if global args are handled by pwb wrapper Userwarning is given.May 1 2022, 1:22 PM
gerritbot added a comment.May 1 2022, 2:02 PM

Change 787912 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] clear _sites cache if called with pwb wrapper

https://gerrit.wikimedia.org/r/787912

gerritbot added a project: Patch-For-Review.May 1 2022, 2:02 PM
gerritbot added a comment.May 1 2022, 2:17 PM

Change 787912 abandoned by Xqt:

[pywikibot/core@master] [bugfix] clear _sites cache if called with pwb wrapper

Reason:

duplicate

https://gerrit.wikimedia.org/r/787912

gerritbot added a comment.May 1 2022, 2:18 PM

Change 787450 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] clear _sites cache if called with pwb wrapper

https://gerrit.wikimedia.org/r/787450

Xqt closed this task as Resolved.May 4 2022, 3:05 AM
Xqt claimed this task.
gerritbot added a comment.May 4 2022, 3:15 AM

Change 787450 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] clear _sites cache if called with pwb wrapper

https://gerrit.wikimedia.org/r/787450

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL