Page MenuHomePhabricator

VisualEditor doesn't need to explicitly exclude Opera < 12 any more
Open, Needs TriagePublic

Description

mw.libs.ve.unsupportedList (formerly named "blacklist") still lists opera: [ [ '<', 12 ] ], but according to https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix Opera < 15 won't receive any JS at all, so this is no longer necessary. The list is specified via VisualEditorBrowserUnsupportedList in extension.json and exposed to the client's JavaScript via wgVisualEditorConfig.

(I actually don't see whether https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/startup/startup.js really blocks all Opera versions below 15, but the test for strict mode does block at least all versions below 12.1.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

JS appears to still be running in Opera 12, and even 11, so either our matrix is wrong or the feature check is wrong. CC @Krinkle

image.png (579×742 px, 82 KB)

I don't think we should be serving JS to environments we explicitly don't trust to work correctly.

thiemowmde renamed this task from VE still explicitely blacklists Opera < 12 to VisualEditor doesn't need to explicitly exclude Opera < 12 any more.Feb 25 2021, 10:58 AM
thiemowmde updated the task description. (Show Details)

This is now definitely true with TLS 1.2 requirement in place since T238038.