Page MenuHomePhabricator

VE still explicitely blacklists Opera < 12
Open, Needs TriagePublic

Description

mw.libs.ve.blacklist.opera is [ '<', 12 ], but according to https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix Opera < 15 won't receive any JS at all, so this is no longer necessary. (I actually don't see whether https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/startup/startup.js really blocks all Opera versions below 15, but the test for strict mode does block at least all versions below 12.1.)

Event Timeline

Schnark created this task.Jun 12 2019, 9:47 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 12 2019, 9:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
marcella moved this task from To Triage to Freezer on the VisualEditor board.Jun 18 2019, 5:09 PM

JS appears to still be running in Opera 12, and even 11, so either our matrix is wrong or the feature check is wrong. CC @Krinkle

I don't think we should be serving JS to environments we explicitly don't trust to work correctly.