| SBisson | |
| Jun 12 2019, 7:07 PM |
| F30381369: image.png | |
| Sep 17 2019, 4:40 PM |
| F30381364: image.png | |
| Sep 17 2019, 4:40 PM |
| F30381316: Screen Shot 2019-09-17 at 12.08.55 PM.png | |
| Sep 17 2019, 4:10 PM |
| F30381193: image.png | |
| Sep 17 2019, 2:42 PM |
| F30079705: Screen Shot 2019-08-23 at 2.49.07 PM.png | |
| Aug 23 2019, 9:52 PM |
| F30079710: Screen Shot 2019-08-23 at 2.50.01 PM.png | |
| Aug 23 2019, 9:52 PM |
| F29649091: image.png | |
| Jun 26 2019, 4:45 PM |
| F29649093: image.png | |
| Jun 26 2019, 4:45 PM |
In order to be consistent with AMC, the tabbed menu on the mobile homepage should have a border bottom.
The desired result can preferably be achieved with:
.minerva__tab-container {
box-shadow: inset 0px -1px 0px 0px rgba(200,204,209,1);
}or, as a fallback, with:
.minerva__tab-container {
border-bottom: 1px solid #C8CCD1;
}| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Homepage: add bottom border to the minerva tabs | mediawiki/extensions/GrowthExperiments | master | +4 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Rileych | T213990 [EPIC] Growth: Newcomer homepage | |||
| Resolved | • MMiller_WMF | T215983 Homepage: mobile version | |||
| Resolved | • Rileych | T230014 Homepage: layout and UI fixes | |||
| Open | None | T225662 Homepage: tabbed menu should have border bottom |
@Cntlsn could you please comment on this? I see a border-top on page-actions-menu, not a border-bottom for the tabs
The screenshot in the task description has the border bottom touching the active tab underline, while the AMC tabs do not appear that way.
Looping in @alexhollender as this was part of the work to keep the homepage design consistent with AMC.
@kostajh @Cntlsn first the easy one: the small gap between the tab underline and the border below is indeed a bug. My apologies for not looping you in on this task which will fix that: T225230.
Regarding the tab menu not having a bottom border: as you mentioned @Cntlsn perhaps there will be other uses for the tabbed menu without the page-actions-menu below in the future (I could see us wanting to do this on special pages like Watchlist, or History), though there aren't plans I know about for such use. Perhaps one option for now is just to create a border below that element but not include it in the component yet? It seems like the alternative would be to create a configurable border as part of the component, and then just make sure it's turned off in cases where it's sitting on-top of another element that already has a border?
Change 530604 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Homepage: add bottom border to the minerva tabs
Change 530604 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: add bottom border to the minerva tabs
@RHo I can't quite tell from the screenshot you posted, but super minor consistency thing — the underline is meant to overlap the border beneath it by 1px:
@RHo I can't quite tell from the screenshot you posted, but super minor consistency thing — the underline is meant to overlap the border beneath it by 1px:
Thanks @alexhollender, good catch. Moving back to In Progress, @SBisson please feel free unassign yourself if you're tied up with NR stuff!
Expected  | Actual (betalabs)  |
Moving back to Upcoming Work because the newcomer tasks project is a higher priority.
