Page MenuHomePhabricator

Homepage: mobile submodule headers
Open, NormalPublic

Description

The submodule headers of the start module don't have correct styling. The div is not inheriting the correct subset of parameters from .growthexperiments-homepage-module .growthexperiments-homepage-module-header, .growthexperiments-homepage-module h2.growthexperiments-homepage-module-header

CurrentDesired

Correct styling could be achieved with the following:

body.mw-special-Homepage .overlay-content .growthexperiments-homepage-module-mobile-overlay .growthexperiments-homepage-module-section-header {
  font-size: 1.1em;
  font-weight: bold;  
}

Event Timeline

SBisson created this task.Jun 12 2019, 7:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2019, 7:13 PM
MMiller_WMF renamed this task from The submodule headers of the start module don't have correct styling to Homepage: mobile submodule headers.Jun 12 2019, 10:25 PM
MMiller_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
MMiller_WMF updated the task description. (Show Details)
MMiller_WMF added subscribers: kostajh, Catrope, Cntlsn and 4 others.
JTannerWMF moved this task from Needs triage to Triaged on the Mobile board.Jun 14 2019, 11:35 AM
Cntlsn closed this task as Declined.Wed, Aug 7, 11:53 AM

Declining this in favor of the new task for all UI fixes at T230014

Cntlsn reopened this task as Open.Mon, Aug 12, 1:55 PM

Re-opening per request at T230014#5409086

Cntlsn triaged this task as Normal priority.Mon, Aug 12, 1:57 PM
Cntlsn updated the task description. (Show Details)

Changed task description with css details about desired styling.
Moving to ready for development column.

Cntlsn updated the task description. (Show Details)Mon, Aug 12, 3:21 PM

Change 530593 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start: update submodules header

https://gerrit.wikimedia.org/r/530593

Change 530593 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start: update submodules header

https://gerrit.wikimedia.org/r/530593