I eventually found a unit test which takes more than 3 seconds on my machine: HashRingTest::testHashRingKetamaMode. It has been introduced in f2e6543c46fff5ce43839982ecd56ebcc10f4d62 by @aaron
It does compute a hashring for 100 nodes as far as I can understand. Would be nice to make it faster, we probably do not need to compute the ring for 100 nodes?
| mediawiki/core : REL1_33 | Reduce HashRing test load to avoid several seconds of CPU |
| mediawiki/core : REL1_32 | Reduce HashRing test load to avoid several seconds of CPU |
| mediawiki/core : master | Reduce HashRing test load to avoid several seconds of CPU |
I assume the slow part would be $ketama_test( 1e5 ). It could probably use 1e4 if there is a speed problem.
@aaron indeed the $ketama_test( 1e5 ) is the culprit and lowering it down to 10000 get it down to half a second. Is there any need to verify it against a larger number? Given the test already ran it for 100 entry, I would guess it could result that output, do the md5sum and compare against the expected md5sum from .c code?
Change 517058 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Reduce HashRing test load to avoid several seconds of CPU
Change 517065 had a related patch set uploaded (by Hashar; owner: Aaron Schulz):
[mediawiki/core@REL1_33] Reduce HashRing test load to avoid several seconds of CPU
Change 517066 had a related patch set uploaded (by Hashar; owner: Aaron Schulz):
[mediawiki/core@REL1_32] Reduce HashRing test load to avoid several seconds of CPU
Change 517058 merged by jenkins-bot:
[mediawiki/core@master] Reduce HashRing test load to avoid several seconds of CPU
Before:
Took 0.93 sec. * testHashRingKetamaMode 0.88 s Passed <= * testHashRingRatios with data set #0 28 ms Passed * testHashRingRatios2 with data set #0 5 ms Passed
After:
Took 61 ms. * testHashRingRatios with data set #0 27 ms Passed * testHashRingKetamaMode 11 ms Passed <= * testHashRingRatios2 with data set #0 5 ms Passed
Change 517066 merged by jenkins-bot:
[mediawiki/core@REL1_32] Reduce HashRing test load to avoid several seconds of CPU
Change 517065 merged by jenkins-bot:
[mediawiki/core@REL1_33] Reduce HashRing test load to avoid several seconds of CPU