Page MenuHomePhabricator
Create Task
Maniphest T225735

Cleanup CI puppet manifests
Closed, ResolvedPublic
Actions

Description

The puppet repository has a lot of obsolete manifests for CI. Lot of them can be cleaned out since most of the test environments are now provided via Docker container.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ci: rename role::ci::slave::labs::common to a profileDzahnoperations/puppetproduction+7 -8
contint: remove obsolete rolesHasharoperations/puppetproduction+0 -88
contint: remove profile::ci::browsersHasharoperations/puppetproduction+0 -32
contint: remove local apache virtualhostHasharoperations/puppetproduction+0 -131
jenkins: remove unused java_path variableDzahnoperations/puppetproduction+0 -4
contint: cleanup no more used materialHasharoperations/puppetproduction+0 -53
contint: remove arcanistHasharoperations/puppetproduction+0 -16
contint: remove contint::phpHasharoperations/puppetproduction+0 -19
contint: no more include ::contint::packages::ruby by defaultHasharoperations/puppetproduction+0 -1
contint: remove sqlite3 debian packageHasharoperations/puppetproduction+0 -7
contint: apply apt::unattend_upgrade at role levelHasharoperations/puppetproduction+2 -9
contint: remove php packagesHasharoperations/puppetproduction+0 -175
releases: inline php packages installationHasharoperations/puppetproduction+27 -1
contint: no more include ::packages::javascript by defaultHasharoperations/puppetproduction+0 -11
contint: remove unneeded profile::ci::hhvmHasharoperations/puppetproduction+0 -49
contint: remove several unused packagesHasharoperations/puppetproduction+0 -42
contint: remove unused contint::packages::pythonHasharoperations/puppetproduction+0 -47
contint: remove MySQL related configurationHasharoperations/puppetproduction+0 -52
contint: drop contint::tmpfsHasharoperations/puppetproduction+0 -31
contint: remove colordiffHasharoperations/puppetproduction+0 -18
Show related patches Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Jun 13 2019, 5:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2019, 5:02 PM
brennen subscribed.Jun 13 2019, 5:02 PM
hashar added a project: Technical-Debt.Jun 13 2019, 5:02 PM

I guess I will do it since I am responsible for almost of the mess that happened there.

Paladox subscribed.Jun 13 2019, 5:03 PM
gerritbot added a comment.Jun 14 2019, 4:17 PM

Change 517091 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove colordiff

https://gerrit.wikimedia.org/r/517091

gerritbot added a project: Patch-For-Review.Jun 14 2019, 4:17 PM
gerritbot added a comment.Jun 14 2019, 4:23 PM

Change 517092 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove unused contint::packages::python

https://gerrit.wikimedia.org/r/517092

gerritbot added a comment.Jun 14 2019, 4:27 PM

Change 517093 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove several unused packages

https://gerrit.wikimedia.org/r/517093

gerritbot added a comment.Jun 14 2019, 4:27 PM

Change 517094 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove unneeded profile::ci::hhvm

https://gerrit.wikimedia.org/r/517094

gerritbot added a comment.Jun 14 2019, 4:31 PM

Change 517095 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove MySQL related configuration

https://gerrit.wikimedia.org/r/517095

gerritbot added a comment.Jun 14 2019, 4:36 PM

Change 517098 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: drop contint::tmpfs

https://gerrit.wikimedia.org/r/517098

Stashbot added a comment.Jun 19 2019, 8:46 AM

Mentioned in SAL (#wikimedia-releng) [2019-06-19T08:46:32Z] <hashar> Removed Debian package colordiff from all slaves | T225735 https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/517091/

Stashbot added a comment.Jun 19 2019, 8:58 AM

Mentioned in SAL (#wikimedia-releng) [2019-06-19T08:58:41Z] <hashar> Removed Debian packages for python / tox etc from all slaves | T225735 https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/517092/

greg added a project: Release-Engineering-Team-TODO.Jun 21 2019, 10:31 PM
Stashbot added a comment.Jun 24 2019, 8:25 AM

Mentioned in SAL (#wikimedia-releng) [2019-06-24T08:25:08Z] <hashar> Removing mysql-server from the CI slaves # https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/517095/ | T225735

greg edited projects, added: Release-Engineering-Team (CI & Testing services); removed: Release-Engineering-Team.Jun 24 2019, 7:51 PM
greg moved this task from Should be empty (use Release-Engineering-Team) to Next on the Release-Engineering-Team-TODO board.Jul 6 2019, 6:03 AM
gerritbot added a comment.Jul 12 2019, 12:31 AM

Change 517091 merged by Dzahn:
[operations/puppet@production] contint: remove colordiff

https://gerrit.wikimedia.org/r/517091

gerritbot added a comment.Jul 12 2019, 12:35 AM

Change 517098 merged by Dzahn:
[operations/puppet@production] contint: drop contint::tmpfs

https://gerrit.wikimedia.org/r/517098

Krinkle awarded a token.Jul 12 2019, 12:36 AM
gerritbot added a comment.Jul 12 2019, 12:47 AM

Change 517095 merged by Dzahn:
[operations/puppet@production] contint: remove MySQL related configuration

https://gerrit.wikimedia.org/r/517095

gerritbot added a comment.Jul 15 2019, 10:10 AM

Change 517092 merged by Alexandros Kosiaris:
[operations/puppet@production] contint: remove unused contint::packages::python

https://gerrit.wikimedia.org/r/517092

gerritbot added a comment.Jul 15 2019, 10:10 AM

Change 517093 merged by Alexandros Kosiaris:
[operations/puppet@production] contint: remove several unused packages

https://gerrit.wikimedia.org/r/517093

gerritbot added a comment.Jul 15 2019, 10:11 AM

Change 517094 merged by Alexandros Kosiaris:
[operations/puppet@production] contint: remove unneeded profile::ci::hhvm

https://gerrit.wikimedia.org/r/517094

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 11:10 AM
gerritbot added a comment.Jul 15 2019, 12:14 PM

Change 523147 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] releases: stop using contint for php, use prod profile

https://gerrit.wikimedia.org/r/523147

gerritbot added a project: Patch-For-Review.Jul 15 2019, 12:14 PM
gerritbot added a comment.Jul 15 2019, 12:23 PM

Change 523148 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove php packages

https://gerrit.wikimedia.org/r/523148

gerritbot added a comment.Jul 15 2019, 12:29 PM

Change 523150 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: apply apt::unattend_upgrade at role level

https://gerrit.wikimedia.org/r/523150

gerritbot added a comment.Jul 15 2019, 7:17 PM

Change 523147 abandoned by Hashar:
releases: use php production profile instead of contint

https://gerrit.wikimedia.org/r/523147

gerritbot added a comment.Jul 15 2019, 7:25 PM

Change 523147 restored by Hashar:
releases: use php production profile instead of contint

https://gerrit.wikimedia.org/r/523147

hashar claimed this task.Jul 17 2019, 3:43 PM
hashar triaged this task as Medium priority.
greg edited projects, added: Release-Engineering-Team-TODO (201907); removed: Release-Engineering-Team-TODO.Jul 17 2019, 3:43 PM
greg moved this task from INBOX to Ready on the Release-Engineering-Team-TODO (201907) board.Jul 17 2019, 3:46 PM
Stashbot added a comment.Jul 18 2019, 1:37 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-18T13:37:53Z] <hashar> integration: rm /etc/apt/sources.list.d/sury-php.list and remove php packages | https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/523148/ | T225735

Stashbot added a comment.Jul 18 2019, 1:48 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-18T13:48:47Z] <hashar> integration: cherry picked https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/523150/ for apt unattended_upgrades | T225735

Stashbot added a comment.Jul 18 2019, 1:51 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-18T13:51:14Z] <hashar> integration: in hiera project config, remove classes: [ contint::packages::apt ] | T225735

gerritbot added a comment.Jul 18 2019, 1:54 PM

Change 524219 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove sqlite3 debian package

https://gerrit.wikimedia.org/r/524219

gerritbot added a comment.Jul 18 2019, 2:00 PM

Change 524221 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: no more include ::packages::javascript by default

https://gerrit.wikimedia.org/r/524221

gerritbot added a comment.Jul 18 2019, 2:08 PM

Change 524224 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: no more include ::contint::packages::ruby by default

https://gerrit.wikimedia.org/r/524224

gerritbot added a comment.Jul 18 2019, 2:18 PM

Change 524225 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove contint::php

https://gerrit.wikimedia.org/r/524225

hashar moved this task from Ready to Doing on the Release-Engineering-Team-TODO (201907) board.Jul 22 2019, 4:26 PM
gerritbot added a comment.Jul 23 2019, 8:08 AM

Change 524221 abandoned by Hashar:
contint: no more include ::packages::javascript by default

Reason:
Abandoning that change for now since we still need NodeJS / Npm on the permanent slaves :-\

https://gerrit.wikimedia.org/r/524221

hashar added a comment.Jul 23 2019, 8:24 AM

The chain of doom:

remote: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/523147 releases: inline php packages installation
remote: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/523148 contint: remove php packages
remote: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/523150 contint: apply apt::unattend_upgrade at role level
remote: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/524219 contint: remove sqlite3 debian package
remote: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/524224 contint: no more include ::contint::packages::ruby by default
remote: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/524225 contint: remove contint::php

gerritbot added a comment.Jul 23 2019, 8:43 AM

Change 523147 merged by Muehlenhoff:
[operations/puppet@production] releases: inline php packages installation

https://gerrit.wikimedia.org/r/523147

gerritbot added a comment.Jul 23 2019, 8:47 AM

Change 523148 merged by Muehlenhoff:
[operations/puppet@production] contint: remove php packages

https://gerrit.wikimedia.org/r/523148

gerritbot added a comment.Jul 23 2019, 8:50 AM

Change 523150 merged by Muehlenhoff:
[operations/puppet@production] contint: apply apt::unattend_upgrade at role level

https://gerrit.wikimedia.org/r/523150

gerritbot added a comment.Jul 23 2019, 8:53 AM

Change 524219 merged by Muehlenhoff:
[operations/puppet@production] contint: remove sqlite3 debian package

https://gerrit.wikimedia.org/r/524219

gerritbot added a comment.Jul 23 2019, 8:58 AM

Change 524224 merged by Muehlenhoff:
[operations/puppet@production] contint: no more include ::contint::packages::ruby by default

https://gerrit.wikimedia.org/r/524224

gerritbot added a comment.Jul 23 2019, 9:02 AM

Change 524225 merged by Muehlenhoff:
[operations/puppet@production] contint: remove contint::php

https://gerrit.wikimedia.org/r/524225

gerritbot added a comment.Jul 23 2019, 11:17 AM

Change 525063 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove arcanist

https://gerrit.wikimedia.org/r/525063

gerritbot added a comment.Jul 25 2019, 4:21 PM

Change 525063 merged by Elukey:
[operations/puppet@production] contint: remove arcanist

https://gerrit.wikimedia.org/r/525063

Jdforrester-WMF edited projects, added: Release-Engineering-Team-TODO (201908); removed: Release-Engineering-Team-TODO (201907), Patch-For-Review.Jul 29 2019, 4:37 PM
Jdforrester-WMF subscribed.

No open patches, but maybe there's more to do?

Jdforrester-WMF moved this task from INBOX to Doing on the Release-Engineering-Team-TODO (201908) board.Jul 29 2019, 4:37 PM
hashar closed this task as Resolved.Sep 3 2019, 12:03 PM

I guess it is good enough for now, the bulk of the cleanup has been accomplished.

hashar reopened this task as Open.May 18 2020, 8:47 AM
hashar merged a task: T252942: Cleanup CI puppet manifests .
hashar added a subscriber: Dzahn.
gerritbot added a comment.May 18 2020, 8:59 AM

Change 597011 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: cleanup no more used material

https://gerrit.wikimedia.org/r/597011

gerritbot added a project: Patch-For-Review.May 18 2020, 8:59 AM
gerritbot added a comment.May 18 2020, 9:07 AM

Change 597013 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove local apache virtualhost

https://gerrit.wikimedia.org/r/597013

gerritbot added a comment.May 18 2020, 9:12 AM

Change 597016 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove profile::ci::browsers

https://gerrit.wikimedia.org/r/597016

gerritbot added a comment.May 18 2020, 9:28 AM

Change 597011 merged by Dzahn:
[operations/puppet@production] contint: cleanup no more used material

https://gerrit.wikimedia.org/r/597011

gerritbot added a comment.May 18 2020, 9:54 AM

Change 597027 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] contint: remove obsolete roles

https://gerrit.wikimedia.org/r/597027

gerritbot added a comment.May 18 2020, 9:57 AM

Change 597028 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] ci: rename role::ci::slave::labs::common to a profile

https://gerrit.wikimedia.org/r/597028

gerritbot added a comment.May 18 2020, 9:57 AM

Change 597026 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] jenkins: remove unused java_path variable

https://gerrit.wikimedia.org/r/597026

gerritbot added a comment.May 18 2020, 10:00 AM

Change 597026 merged by Dzahn:
[operations/puppet@production] jenkins: remove unused java_path variable

https://gerrit.wikimedia.org/r/597026

gerritbot added a comment.May 18 2020, 10:06 AM

Change 597013 merged by Dzahn:
[operations/puppet@production] contint: remove local apache virtualhost

https://gerrit.wikimedia.org/r/597013

gerritbot added a comment.May 18 2020, 10:08 AM

Change 597016 merged by Dzahn:
[operations/puppet@production] contint: remove profile::ci::browsers

https://gerrit.wikimedia.org/r/597016

gerritbot added a comment.May 18 2020, 10:26 AM

Change 597027 merged by Dzahn:
[operations/puppet@production] contint: remove obsolete roles

https://gerrit.wikimedia.org/r/597027

gerritbot added a comment.May 18 2020, 10:47 AM

Change 597028 merged by Dzahn:
[operations/puppet@production] ci: rename role::ci::slave::labs::common to a profile

https://gerrit.wikimedia.org/r/597028

hashar closed this task as Resolved.May 18 2020, 11:47 AM

All patches ninja merged by Daniel

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits